Bug 4013 - road type missing on search results
Summary: road type missing on search results
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-28 10:42 UTC by Nicole C. Engard
Modified: 2015-06-04 23:33 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
street missing on search results (17.41 KB, image/png)
2009-12-28 22:42 UTC, Chris Cormack
Details
street showing on patron record (14.61 KB, image/png)
2009-12-28 22:42 UTC, Chris Cormack
Details
Bug 4013 - road type missing on search results (4.20 KB, patch)
2014-07-16 19:40 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 4013 - road type missing on search results (4.24 KB, patch)
2014-07-25 14:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 4013 [Revised] road type missing on search results (4.36 KB, patch)
2014-07-30 14:27 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 4013 [Revised] road type missing on search results (4.40 KB, patch)
2014-08-02 08:48 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 4013 [Revised] road type missing on search results (4.51 KB, patch)
2014-08-02 19:26 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:22:07 UTC


---- Reported by nengard@gmail.com 2009-12-28 22:42:30 ----

Created an attachment
street missing on search results

On the search results if the road type was entered using the authorized value, then it does not appear on the search results as it does on the patron record.



---- Additional Comments From nengard@gmail.com 2009-12-28 22:42:51 ----

Created an attachment
street showing on patron record





--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:22 UTC  ---

This bug was previously known as _bug_ 4013 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4013
Imported an attachment (id=1774)
Imported an attachment (id=1775)

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
The original submitter of attachment 1774 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1775 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Katrin Fischer 2013-04-13 19:02:00 UTC
This is still the case.
Comment 2 Owen Leonard 2014-07-16 19:40:11 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-07-25 14:17:48 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-07-27 22:02:44 UTC
Hm I think this isn't quite right.

My AV ROADTYPE entry looks like this:
STR Straße Straße

The form allows me to select "Straße". So far so good.

But then in the patron result list, STR is displayed.

From the old database update I think that displaying the code is wrong here, as it should be a migrated numeric(?) id for older installations.

+    my $av_added = $dbh->do(q|
+        INSERT INTO authorised_values(category, authorised_value, lib, lib_opac)
+            SELECT 'ROADTYPE', roadtypeid, road_type, road_type
+            FROM roadtype;
+    |);

The patron detail page displays the description.
Comment 5 Owen Leonard 2014-07-30 14:27:06 UTC Comment hidden (obsolete)
Comment 6 Chris Cormack 2014-08-02 08:48:26 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2014-08-02 19:26:58 UTC
Created attachment 30490 [details] [review]
[PASSED QA] Bug 4013 [Revised] road type missing on search results

On the patron search results page there are several patron fields which
do not show: street number, road type, and state. This patch adds them.

To test, go to Patrons -> Search patrons and perform a search. In the
table of patron search results each patron record should display the
correct information including street number, road type, and state.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes tests and QA script.
Comment 8 Tomás Cohen Arazi 2014-08-05 23:29:19 UTC
Patch pushed to master.

Thanks Owen!