Bug 40146 - Untranslatable actions on vendor
Summary: Untranslatable actions on vendor
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-06-16 07:30 UTC by Inkeri Hakulinen
Modified: 2025-06-25 15:19 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40146: Untranslatable actions on vendor (2.96 KB, patch)
2025-06-17 12:23 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40146: Untranslatable actions on vendor (3.00 KB, patch)
2025-06-25 15:19 UTC, David Flater
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Inkeri Hakulinen 2025-06-16 07:30:31 UTC
Missing translations on some acquisitions-related words in version 25.05

1. Choose some language other than English
2. Go to Acquisitions
3. Search for a vendor and choose one.
4. When on vendor page, choose dropdown-menu from "+New"
5. You see following options: "Basket"*, "Contract"* and "Vendor". The two first are always in English, though "Vendor" is translated".

In Finnish Koha community, we couldn't find an untranslated phrase from Weblate for the begininning of the dropdown-menu. I also tested Admin Kuhn's demo Koha 25.05 at https://koha-community.org/demo/ They have English and German languages installed there, but these translations were missing from there, too.

Can someone please add these terms to be translatable?
Comment 1 Owen Leonard 2025-06-17 12:23:10 UTC
Created attachment 183303 [details] [review]
Bug 40146: Untranslatable actions on vendor

This patch updates the vendor detail view in order to make some menu
items translatable..

To test, apply the patch and run 'yarn build'. Test that the correct
strings are translatable. In this example I'm testing fr-FR:

- Update a translation:

> gulp po:update
> cd misc/translator
> perl translate update fr-FR

- Open the corresponding .po file for the strings pulled from
  JavaScript  e.g.  misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from vue/components/Vendors/VendorShow.vue for
  translation, e.g.:

  #: koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorShow.vue:12
  #, fuzzy
  msgid "Basket"
  msgstr "Paniers"

- Lines 12, 25, and 35 of VendorShow.vue have been modified.
- Delete the line "#, fuzzy"
- Edit the "msgstr" string if ncessary, however you want (it's just for
  testing)
- Install the updated translation:

> perl translate install fr-FR

- Go to Acquisitions -> Vendors -> Vendor details.
- Switch to your updated translation.
- Confirm that the menu items under "New" are translated correctly.

Sponsored-by: Athens County Public Libraries
Comment 2 David Flater 2025-06-25 15:19:02 UTC
Created attachment 183511 [details] [review]
Bug 40146: Untranslatable actions on vendor

This patch updates the vendor detail view in order to make some menu
items translatable..

To test, apply the patch and run 'yarn build'. Test that the correct
strings are translatable. In this example I'm testing fr-FR:

- Update a translation:

> gulp po:update
> cd misc/translator
> perl translate update fr-FR

- Open the corresponding .po file for the strings pulled from
  JavaScript  e.g.  misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from vue/components/Vendors/VendorShow.vue for
  translation, e.g.:

  #: koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorShow.vue:12
  #, fuzzy
  msgid "Basket"
  msgstr "Paniers"

- Lines 12, 25, and 35 of VendorShow.vue have been modified.
- Delete the line "#, fuzzy"
- Edit the "msgstr" string if ncessary, however you want (it's just for
  testing)
- Install the updated translation:

> perl translate install fr-FR

- Go to Acquisitions -> Vendors -> Vendor details.
- Switch to your updated translation.
- Confirm that the menu items under "New" are translated correctly.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Flater <flaterdavid@gmail.com>