Bug 40167 - Curbside pickups - Show link if not configured
Summary: Curbside pickups - Show link if not configured
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Testopia
URL:
Keywords:
Depends on: 40206
Blocks:
  Show dependency treegraph
 
Reported: 2025-06-18 19:25 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2025-06-20 18:21 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function: Curbside pickups


Attachments
Bug 40167: Curbside pickups - Show link if not configured (1.94 KB, patch)
2025-06-20 14:58 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 40167: Curbside pickups - Show link if not configured (2.00 KB, patch)
2025-06-20 18:21 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40167: (follow-up) Tweak message text (1.26 KB, patch)
2025-06-20 18:21 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2025-06-18 19:25:47 UTC
Right now, it displays a warning message when you navigate to Circulation > Curbside pickups, but don't have them configured for the current branch.
Comment 1 Tomás Cohen Arazi (tcohen) 2025-06-20 14:58:37 UTC
Created attachment 183397 [details] [review]
Bug 40167: Curbside pickups - Show link if not configured

If curbside pickups are not configured for the current branch, a correct
message is displayed. It would be helpful to provide a link to the
configuration page right there, if the patron has permissions to set it.

This patch just adds that.

To test:
1. Enable Curbside pickups
2. Make sure you are in a branch that doesn't have any rules for
   curbside pickups
3. Go to Circulation > Curbside pickups
=> SUCCESS: A message about curbside pickups not being configured is
displayed
4. Apply this patch
5. Repeat 3 (reload?)
=> SUCCESS: The message is displayed, but you can now follow a link to
configure the rules.
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 Owen Leonard 2025-06-20 18:21:36 UTC
Created attachment 183400 [details] [review]
Bug 40167: Curbside pickups - Show link if not configured

If curbside pickups are not configured for the current branch, a
correct message is displayed. It would be helpful to provide a link to
the configuration page right there, if the patron has permissions to set
it.

This patch just adds that.

To test:
1. Enable Curbside pickups
2. Make sure you are in a branch that doesn't have any rules for
   curbside pickups
3. Go to Circulation > Curbside pickups
   => SUCCESS: A message about curbside pickups not being configured is
   displayed
4. Apply this patch
5. Repeat 3 (reload?)
   => SUCCESS: The message is displayed, but you can now follow a link
   to configure the rules.
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Owen Leonard 2025-06-20 18:21:38 UTC
Created attachment 183401 [details] [review]
Bug 40167: (follow-up) Tweak message text

I've reworded the message a little bit in order to make it easier to
translate and to make sure the link is descriptive.