Bug 40176 - Add maxLength to the item definition
Summary: Add maxLength to the item definition
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: REST API (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Matt Blenkinsop
URL:
Keywords:
Depends on:
Blocks: 40175 40177 40433
  Show dependency treegraph
 
Reported: 2025-06-18 21:18 UTC by Jonathan Druart
Modified: 2025-07-31 12:23 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.02
Circulation function:


Attachments
Bug 40176: Add tests (2.90 KB, patch)
2025-06-19 09:20 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40176: Add maxLength to item spec file (2.84 KB, patch)
2025-06-19 09:20 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40176: Add tests (2.95 KB, patch)
2025-06-26 07:38 UTC, David Nind
Details | Diff | Splinter Review
Bug 40176: Add maxLength to item spec file (2.88 KB, patch)
2025-06-26 07:38 UTC, David Nind
Details | Diff | Splinter Review
Bug 40176: Add tests (3.01 KB, patch)
2025-07-03 10:05 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 40176: Add maxLength to item spec file (2.95 KB, patch)
2025-07-03 10:06 UTC, Matt Blenkinsop
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-06-18 21:18:43 UTC

    
Comment 1 Jonathan Druart 2025-06-19 09:20:23 UTC
Created attachment 183364 [details] [review]
Bug 40176: Add tests

This patch adds a new subtest to xt/api.t
It ensures that maxLength will appear in the rest api spec file when
there is a size constraint at the DB level
Comment 2 Jonathan Druart 2025-06-19 09:20:25 UTC
Created attachment 183365 [details] [review]
Bug 40176: Add maxLength to item spec file

Test plan:
Apply the "tests" patch first
  prove xt/api.t
=> fail
Apply this patch
=> pass
Comment 3 David Nind 2025-06-26 07:38:37 UTC
Created attachment 183526 [details] [review]
Bug 40176: Add tests

This patch adds a new subtest to xt/api.t
It ensures that maxLength will appear in the rest api spec file when
there is a size constraint at the DB level

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2025-06-26 07:38:40 UTC
Created attachment 183527 [details] [review]
Bug 40176: Add maxLength to item spec file

Test plan:
Apply the "tests" patch first
  prove xt/api.t
=> fail
Apply this patch
=> pass

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Matt Blenkinsop 2025-07-03 10:05:59 UTC
Created attachment 183734 [details] [review]
Bug 40176: Add tests

This patch adds a new subtest to xt/api.t
It ensures that maxLength will appear in the rest api spec file when
there is a size constraint at the DB level

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk>
Comment 6 Matt Blenkinsop 2025-07-03 10:06:01 UTC
Created attachment 183735 [details] [review]
Bug 40176: Add maxLength to item spec file

Test plan:
Apply the "tests" patch first
  prove xt/api.t
=> fail
Apply this patch
=> pass

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk>
Comment 7 Lucas Gass (lukeg) 2025-07-08 21:45:08 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 8 Paul Derscheid 2025-07-10 20:50:48 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 9 Fridolin Somers 2025-07-31 12:23:17 UTC
Enhancement not pushed to 24.11.x