Bug 40198 - Datatables search for data providers is broken
Summary: Datatables search for data providers is broken
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords: release-notes-needed
Depends on:
Blocks:
 
Reported: 2025-06-20 10:29 UTC by Katrin Fischer
Modified: 2025-07-25 20:42 UTC (History)
9 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 40198: Restore data provider search (1.99 KB, patch)
2025-07-24 10:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40198: Fix translatability issue for Active and Inactive (1.28 KB, patch)
2025-07-24 10:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40198: Restore data provider search (2.03 KB, patch)
2025-07-24 13:18 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 40198: Fix translatability issue for Active and Inactive (1.32 KB, patch)
2025-07-24 13:18 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 40198: Restore data provider search (2.13 KB, patch)
2025-07-25 08:29 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 40198: Fix translatability issue for Active and Inactive (1.42 KB, patch)
2025-07-25 08:29 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2025-06-20 10:29:00 UTC
When using the search input field on top of the data providers result list table, the search gets stuck in "Processing".

To test:
- Activate the ERMModule via the system preference
- Add at least one data provider
- In the list of data providers, type anything in the general search field on top
- Confirm that the "Processing" appears, but doesn't go away

In the developer tools it shows:
Uncaught TypeError: col.data is undefined

This was confirmed in main and 24.11.
Comment 1 Jonathan Druart 2025-07-24 10:22:31 UTC
Created attachment 184584 [details] [review]
Bug 40198: Restore data provider search

Uncaught TypeError: col.data is undefined

This patch removes the ability to
* search by status
* search or sort by "last run"

But fix the JS error that will restore the other features

Test plan:
- Activate the ERMModule via the system preference
- Add at least one data provider
- In the list of data providers, type anything in the general search field on top
=> Confirm that you can use the different features of the table without
JS errors
Comment 2 Jonathan Druart 2025-07-24 10:23:42 UTC
Created attachment 184585 [details] [review]
Bug 40198: Fix translatability issue for Active and Inactive
Comment 3 Biblibre Sandboxes 2025-07-24 13:18:00 UTC
Created attachment 184592 [details] [review]
Bug 40198: Restore data provider search

Uncaught TypeError: col.data is undefined

This patch removes the ability to
* search by status
* search or sort by "last run"

But fix the JS error that will restore the other features

Test plan:
- Activate the ERMModule via the system preference
- Add at least one data provider
- In the list of data providers, type anything in the general search field on top
=> Confirm that you can use the different features of the table without
JS errors

Signed-off-by: Michaela <michaela.sieber@kit.edu>
Comment 4 Biblibre Sandboxes 2025-07-24 13:18:03 UTC
Created attachment 184593 [details] [review]
Bug 40198: Fix translatability issue for Active and Inactive

Signed-off-by: Michaela <michaela.sieber@kit.edu>
Comment 5 Marcel de Rooy 2025-07-25 08:29:55 UTC
Created attachment 184620 [details] [review]
Bug 40198: Restore data provider search

Uncaught TypeError: col.data is undefined

This patch removes the ability to
* search by status
* search or sort by "last run"

But fix the JS error that will restore the other features

Test plan:
- Activate the ERMModule via the system preference
- Add at least one data provider
- In the list of data providers, type anything in the general search field on top
=> Confirm that you can use the different features of the table without
JS errors

Signed-off-by: Michaela <michaela.sieber@kit.edu>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Marcel de Rooy 2025-07-25 08:29:58 UTC
Created attachment 184621 [details] [review]
Bug 40198: Fix translatability issue for Active and Inactive

Signed-off-by: Michaela <michaela.sieber@kit.edu>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Lucas Gass (lukeg) 2025-07-25 20:39:59 UTC
Nice work everyone!

Pushed to main for 25.11