Bug 40245 - Support option to display firstname in memberresultst
Summary: Support option to display firstname in memberresultst
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: CJ Lynce
QA Contact: Laura Escamilla
URL:
Keywords: release-notes-needed
: 40484 (view as bug list)
Depends on:
Blocks:
 
Reported: 2025-06-25 18:20 UTC by Chip Halvorsen
Modified: 2025-10-10 17:16 UTC (History)
8 users (show)

See Also:
GIT URL:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
A new system preference 'ShowFirstIfDifferentThanPreferred' toggles the ability for a patron's documented first name to be displayed alongside their Preferred name, when different, during patron search. This allows for library staff to easier identify and distinguish between patron record with similar names or when an ID does not match the patron's preferred name.
Version(s) released in:
Circulation function:


Attachments
Bug 40245: Add new system preference ShowFirstIfDifferentThanPreferred (3.75 KB, patch)
2025-07-22 18:56 UTC, CJ Lynce
Details | Diff | Splinter Review
Bug 40245: Show firstname in patron search results when different than preferred_name (7.96 KB, patch)
2025-07-22 18:57 UTC, CJ Lynce
Details | Diff | Splinter Review
Bug 40245: Show firstname in patron search results when different than preferred_name (8.03 KB, patch)
2025-07-25 14:06 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review
Bug 40245: Add new system preference ShowFirstIfDifferentThanPreferred (3.82 KB, patch)
2025-07-25 14:07 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review
Bug 40245: Show firstname in patron search results when different than preferred_name (8.03 KB, patch)
2025-07-25 14:08 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review
Bug 40245: Show firstname in patron search results when different than preferred_name (8.08 KB, patch)
2025-08-20 17:23 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 40245: Add new system preference ShowFirstIfDifferentThanPreferred (3.88 KB, patch)
2025-08-20 17:26 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 40245: Show firstname in patron search results when different than preferred_name (8.08 KB, patch)
2025-08-20 17:26 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 40245: Add new system preference ShowFirstIfDifferentThanPreferred (3.95 KB, patch)
2025-09-22 15:45 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 40245: Show firstname in patron search results when different than preferred_name (8.15 KB, patch)
2025-09-22 15:45 UTC, Laura Escamilla
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chip Halvorsen 2025-06-25 18:20:06 UTC
Circulation staff would find it very useful to see firstname in addition to preferred_name in the patron search results table (memberresultst). Currently at 24.11+, only the preferred name is displayed.

One way to handle this might be to add firstname as a line at between address and email address. 

SMITH, KAT 
  123 MAIN ST.
  ANYTOWN, STATE/PROVINCE POSTCODE
Firstname: KATELYNN
Email: X@Y.Z

Or we might want to put the firstname in parenthesis.
SMITH, KAT (Firstname: KATELYNN)
  123 MAIN ST.
  ANYTOWN, STATE/PROVINCE POSTCODE
Email: X@Y.Z

Having the firstname appear somewhere would help disambiguate similar patron names in the search results. Even better would be logic that only displayed the Firstname when it differs from the Preferred_name.

This should be made optional. Some libraries might not want firstname to appear here, to avoid accidentally deadnaming a patron.
Comment 1 CJ Lynce 2025-07-22 18:56:41 UTC
Created attachment 184501 [details] [review]
Bug 40245: Add new system preference ShowFirstIfDifferentThanPreferred

Adds a new system preference ShowFirstIfDifferentThanPreferred to allow a
    patron's firstname to be shown in search results when different than
    their preferred name.
Comment 2 CJ Lynce 2025-07-22 18:57:26 UTC
Created attachment 184502 [details] [review]
Bug 40245: Show firstname in patron search results when different than preferred_name

This patch shows the patron's firstname in search results and autosuggestions when
    thier preferred_name is different than their first name. Requires that sysprep
    ShowFirstIfDifferentThanPreferred is enabled. When disabled, only the preferred
    name shows in results.

Test plan:
0. Apply patches and login to the staff interface.
1. Edit a patron to give a different preferred name than first.
2. Return to home page and search for the patron in the quick-search bar.
3. Verify patron shows up in autosuggest list, showing preferred name only.
4. Verify patron shows up in regular list (member.pl) with preferred name showing only.
5. Change syspref ShowFirstIfDifferentThanPreferred to "Show" and save.
6. Return to home page and search for the patron in the quick-search bar.
7. Verify patron shows up in autosuggest list, showing preferred name, and firstname in brackets.
8. Verify patron shows up in regular list (member.pl) with preferred name, and firstname in brackets.

Sponsored-by: Westlake Porter Public Library <https://westlakelibrary.org>
Comment 3 CJ Lynce 2025-07-24 19:36:17 UTC
*** Bug 40484 has been marked as a duplicate of this bug. ***
Comment 4 Emily Lamancusa (emlam) 2025-07-25 14:06:04 UTC
Created attachment 184637 [details] [review]
Bug 40245: Show firstname in patron search results when different than preferred_name

This patch shows the patron's firstname in search results and autosuggestions when
    thier preferred_name is different than their first name. Requires that sysprep
    ShowFirstIfDifferentThanPreferred is enabled. When disabled, only the preferred
    name shows in results.

Test plan:
0. Apply patches and login to the staff interface.
1. Edit a patron to give a different preferred name than first.
2. Return to home page and search for the patron in the quick-search bar.
3. Verify patron shows up in autosuggest list, showing preferred name only.
4. Verify patron shows up in regular list (member.pl) with preferred name showing only.
5. Change syspref ShowFirstIfDifferentThanPreferred to "Show" and save.
6. Return to home page and search for the patron in the quick-search bar.
7. Verify patron shows up in autosuggest list, showing preferred name, and firstname in brackets.
8. Verify patron shows up in regular list (member.pl) with preferred name, and firstname in brackets.

Sponsored-by: Westlake Porter Public Library <https://westlakelibrary.org>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 5 Emily Lamancusa (emlam) 2025-07-25 14:07:57 UTC
Created attachment 184638 [details] [review]
Bug 40245: Add new system preference ShowFirstIfDifferentThanPreferred

Adds a new system preference ShowFirstIfDifferentThanPreferred to allow a
    patron's firstname to be shown in search results when different than
    their preferred name.

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 6 Emily Lamancusa (emlam) 2025-07-25 14:08:03 UTC
Created attachment 184639 [details] [review]
Bug 40245: Show firstname in patron search results when different than preferred_name

This patch shows the patron's firstname in search results and autosuggestions when
    thier preferred_name is different than their first name. Requires that sysprep
    ShowFirstIfDifferentThanPreferred is enabled. When disabled, only the preferred
    name shows in results.

Test plan:
0. Apply patches and login to the staff interface.
1. Edit a patron to give a different preferred name than first.
2. Return to home page and search for the patron in the quick-search bar.
3. Verify patron shows up in autosuggest list, showing preferred name only.
4. Verify patron shows up in regular list (member.pl) with preferred name showing only.
5. Change syspref ShowFirstIfDifferentThanPreferred to "Show" and save.
6. Return to home page and search for the patron in the quick-search bar.
7. Verify patron shows up in autosuggest list, showing preferred name, and firstname in brackets.
8. Verify patron shows up in regular list (member.pl) with preferred name, and firstname in brackets.

Sponsored-by: Westlake Porter Public Library <https://westlakelibrary.org>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 7 Emily Lamancusa (emlam) 2025-07-25 14:45:02 UTC
Thanks, CJ! This looks nice and works as advertised!

Testing notes:
- After applying patch, run updatedatabase and clear browser cache
Comment 8 Biblibre Sandboxes 2025-08-20 17:23:08 UTC
Created attachment 185601 [details] [review]
Bug 40245: Show firstname in patron search results when different than preferred_name

This patch shows the patron's firstname in search results and autosuggestions when
    thier preferred_name is different than their first name. Requires that sysprep
    ShowFirstIfDifferentThanPreferred is enabled. When disabled, only the preferred
    name shows in results.

Test plan:
0. Apply patches and login to the staff interface.
1. Edit a patron to give a different preferred name than first.
2. Return to home page and search for the patron in the quick-search bar.
3. Verify patron shows up in autosuggest list, showing preferred name only.
4. Verify patron shows up in regular list (member.pl) with preferred name showing only.
5. Change syspref ShowFirstIfDifferentThanPreferred to "Show" and save.
6. Return to home page and search for the patron in the quick-search bar.
7. Verify patron shows up in autosuggest list, showing preferred name, and firstname in brackets.
8. Verify patron shows up in regular list (member.pl) with preferred name, and firstname in brackets.

Sponsored-by: Westlake Porter Public Library <https://westlakelibrary.org>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Chip <chip.halvorsen@westlakelibrary.org>
Comment 9 Chip Halvorsen 2025-08-20 17:25:39 UTC
Tested and everything works as expected.
Comment 10 Biblibre Sandboxes 2025-08-20 17:26:20 UTC
Created attachment 185602 [details] [review]
Bug 40245: Add new system preference ShowFirstIfDifferentThanPreferred

Adds a new system preference ShowFirstIfDifferentThanPreferred to allow a
    patron's firstname to be shown in search results when different than
    their preferred name.

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Chip <chip.halvorsen@westlakelibrary.org>
Comment 11 Biblibre Sandboxes 2025-08-20 17:26:22 UTC
Created attachment 185603 [details] [review]
Bug 40245: Show firstname in patron search results when different than preferred_name

This patch shows the patron's firstname in search results and autosuggestions when
    thier preferred_name is different than their first name. Requires that sysprep
    ShowFirstIfDifferentThanPreferred is enabled. When disabled, only the preferred
    name shows in results.

Test plan:
0. Apply patches and login to the staff interface.
1. Edit a patron to give a different preferred name than first.
2. Return to home page and search for the patron in the quick-search bar.
3. Verify patron shows up in autosuggest list, showing preferred name only.
4. Verify patron shows up in regular list (member.pl) with preferred name showing only.
5. Change syspref ShowFirstIfDifferentThanPreferred to "Show" and save.
6. Return to home page and search for the patron in the quick-search bar.
7. Verify patron shows up in autosuggest list, showing preferred name, and firstname in brackets.
8. Verify patron shows up in regular list (member.pl) with preferred name, and firstname in brackets.

Sponsored-by: Westlake Porter Public Library <https://westlakelibrary.org>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Chip <chip.halvorsen@westlakelibrary.org>
Comment 12 Laura Escamilla 2025-09-22 15:45:29 UTC
Created attachment 186732 [details] [review]
Bug 40245: Add new system preference ShowFirstIfDifferentThanPreferred

Adds a new system preference ShowFirstIfDifferentThanPreferred to allow a
    patron's firstname to be shown in search results when different than
    their preferred name.

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Chip <chip.halvorsen@westlakelibrary.org>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 13 Laura Escamilla 2025-09-22 15:45:32 UTC
Created attachment 186733 [details] [review]
Bug 40245: Show firstname in patron search results when different than preferred_name

This patch shows the patron's firstname in search results and autosuggestions when
    thier preferred_name is different than their first name. Requires that sysprep
    ShowFirstIfDifferentThanPreferred is enabled. When disabled, only the preferred
    name shows in results.

Test plan:
0. Apply patches and login to the staff interface.
1. Edit a patron to give a different preferred name than first.
2. Return to home page and search for the patron in the quick-search bar.
3. Verify patron shows up in autosuggest list, showing preferred name only.
4. Verify patron shows up in regular list (member.pl) with preferred name showing only.
5. Change syspref ShowFirstIfDifferentThanPreferred to "Show" and save.
6. Return to home page and search for the patron in the quick-search bar.
7. Verify patron shows up in autosuggest list, showing preferred name, and firstname in brackets.
8. Verify patron shows up in regular list (member.pl) with preferred name, and firstname in brackets.

Sponsored-by: Westlake Porter Public Library <https://westlakelibrary.org>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Chip <chip.halvorsen@westlakelibrary.org>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 14 Lucas Gass (lukeg) 2025-10-09 20:42:35 UTC
Should we add a Cypress test?
Comment 15 Jonathan Druart 2025-10-10 03:36:54 UTC
I think we should have "Patron" and "Firstname" in the name of the pref. The current version "ShowFirstIfDifferentThanPreferred" is confusing IMO.
Comment 16 Jonathan Druart 2025-10-10 03:52:00 UTC
1. What does "showlegal" mean?

2.
  var showFirstIfDifferentThanPreferred = [% Koha.Preference('ShowFirstIfDifferentThanPreferred') | html %];

Should be 
  var showFirstIfDifferentThanPreferred = [% Koha.Preference('ShowFirstIfDifferentThanPreferred') ? 1 : 0 | html %];

To prevent a JS error if the pref is not set.

3. js-patron-format.inc is going to be removed on bug 40958, in favor of a js file, and the TT variable won't be accessible. Why don't you pass the "showFirstIfDifferentThanPreferred" flag from the patron search if the pref is set? You won't need to check the pref in the inc file

4. Commit message states that it affects "search results and autosuggestions" but it's actually all patron searches (bug title should also be adjusted)

5.
(In reply to Lucas Gass (lukeg) from comment #14)
> Should we add a Cypress test?

Yes, that would be great!
Comment 17 Jonathan Druart 2025-10-10 03:53:12 UTC
Feel free to ask if you have questions or need help!
Comment 18 CJ Lynce 2025-10-10 13:34:25 UTC
(In reply to Jonathan Druart from comment #16)
> 1. What does "showlegal" mean?
Show legal name (vs nickname or dead name), though in retrospect, 'showfirstname' would be more appropriate and match other language. 

> 2. [...]
Thanks for catching, I'll make that change (and remember for next time)

> 3. [...]
Good idea, and thanks for pointing out bug 40958. I'll adjust to incorporate those changes.

> 4. Commit message states that it affects "search results and
> autosuggestions" but it's actually all patron searches (bug title should
> also be adjusted)

Thanks and good point, I will adjust. 

> 5.
> (In reply to Lucas Gass (lukeg) from comment #14)
> > Should we add a Cypress test?

I might need some help on this one, I've not written Cypress tests before. Is there a past bug or two that has some good Koha-related examples to look at?

Thanks!
Comment 19 CJ Lynce 2025-10-10 17:16:51 UTC
(In reply to Jonathan Druart from comment #15)
> I think we should have "Patron" and "Firstname" in the name of the pref. The
> current version "ShowFirstIfDifferentThanPreferred" is confusing IMO.

Is there a limit on how long a system pref name could/should be? 
ShowPatronFirstnameIfDifferentThanPreferredname is more clear, but long (48 chr)
It is shorter than PatronSelfRegistrationExpireTemporaryAccountsDelay (51 chr)