Bug 41003 - Missing Cypress tests for patron display
Summary: Missing Cypress tests for patron display
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 40958
  Show dependency treegraph
 
Reported: 2025-10-13 13:16 UTC by Jonathan Druart
Modified: 2025-10-31 21:30 UTC (History)
2 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 41003: Remove extra spaces (1.68 KB, patch)
2025-10-13 13:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41003: Add Cypress tests to cover patron formatting (4.77 KB, patch)
2025-10-13 13:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41003: Add Cypress tests to cover patron formatting (4.76 KB, patch)
2025-10-13 13:36 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41003: Add Cypress tests to cover patron formatting (4.82 KB, patch)
2025-10-31 11:01 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-10-13 13:16:03 UTC
Several enhancements in the queue related to the patron display. We should first have Cypress test for main before starting adding more changes.
Comment 1 Jonathan Druart 2025-10-13 13:17:18 UTC
Created attachment 187837 [details] [review]
Bug 41003: Remove extra spaces
Comment 2 Jonathan Druart 2025-10-13 13:17:20 UTC
Created attachment 187838 [details] [review]
Bug 41003: Add Cypress tests to cover patron formatting
Comment 3 Jonathan Druart 2025-10-13 13:36:03 UTC
Created attachment 187840 [details] [review]
Bug 41003: Add Cypress tests to cover patron formatting
Comment 4 Lucas Gass (lukeg) 2025-10-22 13:09:20 UTC
No one tested this?
Comment 5 Jonathan Druart 2025-10-23 07:31:22 UTC
(In reply to Lucas Gass (lukeg) from comment #4)
> No one tested this?

I didn't think it was needed for several reasons:
* This patch adds tests for "main", nothing else (the "Remove extra spaces" change is not something visible on the interface, only to make the tests pass)
* It has been added as blocker of other bugs and I didn't want to block them because of tests (especially bug 40245 that is not from me)
* Follow-up bugs will extend those tests, and so testers and QAers will confirm they work anyway

But feel free to ask for a QA stamp if you are not comfortable with the patches!
Comment 6 Nick Clemens (kidclamp) 2025-10-31 11:01:03 UTC
Created attachment 188802 [details] [review]
Bug 41003: Add Cypress tests to cover patron formatting

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 7 Nick Clemens (kidclamp) 2025-10-31 11:01:41 UTC
Conflicts from bug 30568 - I don't believe first patch was needed any longer - dropped
Comment 8 Lucas Gass (lukeg) 2025-10-31 21:30:52 UTC
Nice work everyone!

Pushed to main for 25.11