Bug 40301 - Missing Cypress tests for 'Type' column visibility
Summary: Missing Cypress tests for 'Type' column visibility
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 40181 40281
Blocks: 40345
  Show dependency treegraph
 
Reported: 2025-07-03 11:59 UTC by Jonathan Druart
Modified: 2025-07-21 20:03 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 40301: Add insertSampleCheckout (6.27 KB, patch)
2025-07-03 12:13 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40301: (bug 40299 follow-up) Add Cypress tests (1.48 KB, patch)
2025-07-03 12:13 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40301: Add insertSampleCheckout (5.67 KB, patch)
2025-07-10 12:47 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40301: (bug 40299 follow-up) Add Cypress tests (1.48 KB, patch)
2025-07-10 12:47 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40301: Add insertSampleCheckout (5.72 KB, patch)
2025-07-17 15:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40301: (bug 40299 follow-up) Add Cypress tests (1.52 KB, patch)
2025-07-17 15:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40301: Add insertSampleCheckout (5.78 KB, patch)
2025-07-18 11:25 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 40301: (bug 40299 follow-up) Add Cypress tests (1.59 KB, patch)
2025-07-18 11:25 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-07-03 11:59:06 UTC

    
Comment 1 Jonathan Druart 2025-07-03 12:13:13 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2025-07-03 12:13:15 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2025-07-03 12:14:09 UTC
Test plan:
The new Cypress tests should pass.

yarn cypress run --spec t/cypress/integration/KohaTable/CirculationHistory_spec.ts

If you revert bug 40299 it should fail.
Comment 4 Jonathan Druart 2025-07-10 12:47:41 UTC
Created attachment 183938 [details] [review]
Bug 40301: Add insertSampleCheckout
Comment 5 Jonathan Druart 2025-07-10 12:47:43 UTC
Created attachment 183939 [details] [review]
Bug 40301: (bug 40299 follow-up) Add Cypress tests
Comment 6 Owen Leonard 2025-07-17 15:48:41 UTC
Created attachment 184214 [details] [review]
Bug 40301: Add insertSampleCheckout

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 7 Owen Leonard 2025-07-17 15:48:44 UTC
Created attachment 184215 [details] [review]
Bug 40301: (bug 40299 follow-up) Add Cypress tests

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 8 Martin Renvoize (ashimema) 2025-07-18 11:25:24 UTC
Created attachment 184338 [details] [review]
Bug 40301: Add insertSampleCheckout

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 9 Martin Renvoize (ashimema) 2025-07-18 11:25:26 UTC
Created attachment 184339 [details] [review]
Bug 40301: (bug 40299 follow-up) Add Cypress tests

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 10 Lucas Gass (lukeg) 2025-07-18 16:40:00 UTC
  Running:  CirculationHistory_spec.ts                                                      (1 of 1)


  1) "before all" hook for "'Type' column should be hidden"

  0 passing (361ms)
  1 failing

  1) members/readingrec
       "before all" hook for "'Type' column should be hidden":
     Error: Cypress tests tests require 'RESTBasicAuth'. Skipping suite.

Because this error occurred during a `before all` hook we are skipping all of the remaining tests.
      at Context.eval (webpack://koha/./t/cypress/support/e2e.js:1944:18)
Comment 11 Jonathan Druart 2025-07-21 07:45:11 UTC
(In reply to Lucas Gass (lukeg) from comment #10)
>   Running:  CirculationHistory_spec.ts                                      
> (1 of 1)
> 
> 
>   1) "before all" hook for "'Type' column should be hidden"
> 
>   0 passing (361ms)
>   1 failing
> 
>   1) members/readingrec
>        "before all" hook for "'Type' column should be hidden":
>      Error: Cypress tests tests require 'RESTBasicAuth'. Skipping suite.
> 
> Because this error occurred during a `before all` hook we are skipping all
> of the remaining tests.
>       at Context.eval (webpack://koha/./t/cypress/support/e2e.js:1944:18)

See "Bug 40174: Require RESTBasicAuth turned ON" and https://gitlab.com/koha-community/koha-misc4dev/-/issues/91
Comment 12 Lucas Gass (lukeg) 2025-07-21 20:03:31 UTC
Nice work everyone!

Pushed to main for 25.11