Created attachment 183752 [details] [review] Bug 40301: Add insertSampleCheckout
Created attachment 183753 [details] [review] Bug 40301: (bug 40299 follow-up) Add Cypress tests
Test plan: The new Cypress tests should pass. yarn cypress run --spec t/cypress/integration/KohaTable/CirculationHistory_spec.ts If you revert bug 40299 it should fail.
Created attachment 183938 [details] [review] Bug 40301: Add insertSampleCheckout
Created attachment 183939 [details] [review] Bug 40301: (bug 40299 follow-up) Add Cypress tests
Created attachment 184214 [details] [review] Bug 40301: Add insertSampleCheckout Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 184215 [details] [review] Bug 40301: (bug 40299 follow-up) Add Cypress tests Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 184338 [details] [review] Bug 40301: Add insertSampleCheckout Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 184339 [details] [review] Bug 40301: (bug 40299 follow-up) Add Cypress tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Running: CirculationHistory_spec.ts (1 of 1) 1) "before all" hook for "'Type' column should be hidden" 0 passing (361ms) 1 failing 1) members/readingrec "before all" hook for "'Type' column should be hidden": Error: Cypress tests tests require 'RESTBasicAuth'. Skipping suite. Because this error occurred during a `before all` hook we are skipping all of the remaining tests. at Context.eval (webpack://koha/./t/cypress/support/e2e.js:1944:18)
(In reply to Lucas Gass (lukeg) from comment #10) > Running: CirculationHistory_spec.ts > (1 of 1) > > > 1) "before all" hook for "'Type' column should be hidden" > > 0 passing (361ms) > 1 failing > > 1) members/readingrec > "before all" hook for "'Type' column should be hidden": > Error: Cypress tests tests require 'RESTBasicAuth'. Skipping suite. > > Because this error occurred during a `before all` hook we are skipping all > of the remaining tests. > at Context.eval (webpack://koha/./t/cypress/support/e2e.js:1944:18) See "Bug 40174: Require RESTBasicAuth turned ON" and https://gitlab.com/koha-community/koha-misc4dev/-/issues/91
Nice work everyone! Pushed to main for 25.11