Bug 40314 - Table columns aren't showing/responding properly in opac course reserves
Summary: Table columns aren't showing/responding properly in opac course reserves
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Matt Blenkinsop
QA Contact: Testopia
URL:
Keywords:
Depends on: 36640
Blocks:
  Show dependency treegraph
 
Reported: 2025-07-07 09:38 UTC by Matt Blenkinsop
Modified: 2025-07-07 10:09 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40314: Correct the columns definitions in the OPAC course reserves table (1.46 KB, patch)
2025-07-07 09:41 UTC, Matt Blenkinsop
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2025-07-07 09:38:36 UTC
There appears to be a typo in the datatable definition for the course reserves table and the thesis table which is causing the tables to not behave as expected

To test:
1) In the interface, navigate to the course reserves page and add a public note to the course reserve provided in the default dataset
2) In the OPAC, click on course reserves
3) Re-size your screen to mobile mode
4) There should be a plus icon in the final column to show additional information from the columns hidden in mobile mode but it is missing
Comment 1 Matt Blenkinsop 2025-07-07 09:41:12 UTC
Created attachment 183824 [details] [review]
Bug 40314: Correct the columns definitions in the OPAC course reserves table

To test:
1) In the interface, navigate to the course reserves page and add a public note to the course reserve provided in the default dataset
2) In the OPAC, click on course reserves
3) Re-size your screen to mobile mode
4) There should be a plus icon in the final column to show additional information from the columns hidden in mobile mode but it is missing
5) Apply patch
6) Hard refresh the page
7) The icon should now be visible
Comment 2 Jonathan Druart 2025-07-07 10:09:12 UTC
-                    asColumnDefs: [{ aTargets: [1], sType: "nsb-nse" }],

There is another one, same table.

We could do this remove it and add it:

                     columnDefs: [
+                        { type: "nsb-nse", targets: [1] },
                         { className: "dtr-control", orderable: false, targets: -1 },
                     ],

But I don't understand why it targets column 1, the second column is "Department". I guess it's an error and should be 0? But... actually, we use nsb-nse when we display a biblio record title, what we don't do here, so maybe just remove this nsb-nse rule here?

It's coming from 
  commit 6179fcce8cffa33a19e997e9ee6a88ae22ce43d5
  Author: Lucas Gass <lucas@bywatersolutions.com>
  Bug 23547: Add column configuration to course reserves table in the OPAC

@Lucas, was it intentional?