t/db_dependent/Auth_with_shibboleth.t .. 1/5 GetPreparedLetter called at t/db_dependent/Auth_with_shibboleth.t line 73. EnqueueLetter called at t/db_dependent/Auth_with_shibboleth.t line 80. SendQueuedMessages called with message_id: 42 at t/db_dependent/Auth_with_shibboleth.t line 90.
Created attachment 183834 [details] [review] Bug 40317: Remove warnings from Auth_with_shibboleth.t output t/db_dependent/Auth_with_shibboleth.t .. 1/5 GetPreparedLetter called at t/db_dependent/Auth_with_shibboleth.t line 73. EnqueueLetter called at t/db_dependent/Auth_with_shibboleth.t line 80. SendQueuedMessages called with message_id: 42 at t/db_dependent/Auth_with_shibboleth.t line 90. Not sure what exactly is going on here, but warnings_are is not supposed to show the warnings in the output. I think it's because of the logger mock. A workaround is to use a variable we increment then compare to see if we reach the sub. Test plan: % prove t/db_dependent/Auth_with_shibboleth.t should return green without warnings
Created attachment 183853 [details] [review] Bug 40317: Remove warnings from Auth_with_shibboleth.t output t/db_dependent/Auth_with_shibboleth.t .. 1/5 GetPreparedLetter called at t/db_dependent/Auth_with_shibboleth.t line 73. EnqueueLetter called at t/db_dependent/Auth_with_shibboleth.t line 80. SendQueuedMessages called with message_id: 42 at t/db_dependent/Auth_with_shibboleth.t line 90. Not sure what exactly is going on here, but warnings_are is not supposed to show the warnings in the output. I think it's because of the logger mock. A workaround is to use a variable we increment then compare to see if we reach the sub. Test plan: % prove t/db_dependent/Auth_with_shibboleth.t should return green without warnings Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x