Bug 40319 - Fix spacing in address display include
Summary: Fix spacing in address display include
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 38664
Blocks: 40320
  Show dependency treegraph
 
Reported: 2025-07-07 13:25 UTC by Owen Leonard
Modified: 2025-07-11 21:29 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 40319: Fix spacing in address display include (6.20 KB, patch)
2025-07-07 13:45 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40319: Fix spacing in address display include (6.26 KB, patch)
2025-07-10 12:36 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2025-07-07 13:25:30 UTC
Bug 38664 introduced indentation and spacing changes which affected the way addresses are displayed in member-display-address-style.inc. This caused spaces to disappear between address parts, for example between city and state in the US layout.
Comment 1 Owen Leonard 2025-07-07 13:45:19 UTC
Created attachment 183842 [details] [review]
Bug 40319: Fix spacing in address display include

This patch makes some spacing changes to the address display include in
order to prevent address parts (e.g. city, state, zip, etc) from missing
spaces in between.

To test, apply the patch and locate or edit a patron record to include
data in all main address fields.

- Check out to the patron and check the display of the address in the
  sidebar. Confirm that the spacing is correct.
- Test with all variations of the AddressFormat system preference.
- Test with and without the use of road types (Administration ->
  Authorized values -> ROADTYPE) and street numbers.

Sponsored-by: Athens County Public Libraries
Comment 2 Jonathan Druart 2025-07-07 15:04:54 UTC
I've added Cypress tests for this on bug 40320.
Comment 3 Owen Leonard 2025-07-07 16:05:29 UTC
(In reply to Jonathan Druart from comment #2)
> I've added Cypress tests for this on bug 40320.

Thank you!
Comment 4 Martin Renvoize (ashimema) 2025-07-10 12:36:55 UTC
Created attachment 183937 [details] [review]
Bug 40319: Fix spacing in address display include

This patch makes some spacing changes to the address display include in
order to prevent address parts (e.g. city, state, zip, etc) from missing
spaces in between.

To test, apply the patch and locate or edit a patron record to include
data in all main address fields.

- Check out to the patron and check the display of the address in the
  sidebar. Confirm that the spacing is correct.
- Test with all variations of the AddressFormat system preference.
- Test with and without the use of road types (Administration ->
  Authorized values -> ROADTYPE) and street numbers.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 5 Lucas Gass (lukeg) 2025-07-11 21:29:49 UTC
Nice work everyone!

Pushed to main for 25.11