Bug 38664 introduced indentation and spacing changes which affected the way addresses are displayed in member-display-address-style.inc. This caused spaces to disappear between address parts, for example between city and state in the US layout.
Created attachment 183842 [details] [review] Bug 40319: Fix spacing in address display include This patch makes some spacing changes to the address display include in order to prevent address parts (e.g. city, state, zip, etc) from missing spaces in between. To test, apply the patch and locate or edit a patron record to include data in all main address fields. - Check out to the patron and check the display of the address in the sidebar. Confirm that the spacing is correct. - Test with all variations of the AddressFormat system preference. - Test with and without the use of road types (Administration -> Authorized values -> ROADTYPE) and street numbers. Sponsored-by: Athens County Public Libraries
I've added Cypress tests for this on bug 40320.
(In reply to Jonathan Druart from comment #2) > I've added Cypress tests for this on bug 40320. Thank you!
Created attachment 183937 [details] [review] Bug 40319: Fix spacing in address display include This patch makes some spacing changes to the address display include in order to prevent address parts (e.g. city, state, zip, etc) from missing spaces in between. To test, apply the patch and locate or edit a patron record to include data in all main address fields. - Check out to the patron and check the display of the address in the sidebar. Confirm that the spacing is correct. - Test with all variations of the AddressFormat system preference. - Test with and without the use of road types (Administration -> Authorized values -> ROADTYPE) and street numbers. Sponsored-by: Athens County Public Libraries Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Nice work everyone! Pushed to main for 25.11