In the Tools module, the sidebar menu is broken into categories Patrons & Circulation and Additional Tools. In theory, a category is shown if the user has at least one permission within that category. However, there's at least one permission that didn't get properly added to the bit of the page template that controls display of the category. To reproduce: 1 - have or create a user with the permissions batch_extend_due_dates edit_quotes but no other Tools 2 - log into koha as that user, go to Tools module, confirm both Batch Extend Due Dates and Quote Editor are available from the Tools module home page 3 - Click into either available tool, confirm the sidebar menu contains the category Additional Tools and a link to Quote Editor, but nothing else 4 - add the edit_notices permission to your user 5 - reload your page from step 3, confirm the sidebar menu now also contains the Patrons & Circulation category with both Notices & Slips and Batch Extend Due Dates.
After reviewing the template, it looks like batch_extend_due_dates is the only one that's been missed at the category level, so this is really small.
Created attachment 183891 [details] [review] Bug 40332: Show tools sidebar category for batch extend due dates permission To test: 1 - have or create a user with the permissions batch_extend_due_dates edit_quotes but no other Tools 2 - log into koha as that user, go to Tools module, confirm both Batch Extend Due Dates and Quote Editor are available from the Tools module home page 3 - Click into either available tool, confirm the sidebar menu contains the category Additional Tools and a link to Quote Editor, but nothing else 4 - add the edit_notices permission to your user 5 - reload your page from step 3, confirm the sidebar menu now also contains the Patrons & Circulation category with both Notices & Slips and Batch Extend Due Dates. 6 - apply patch, restart services, reload page, confirm nothing has changed 7 - remove the edit_notices permission from your user 8 - reload your page from step 3, confirm the sidebar menu now contains the Patrons & Circulation category with only Batch Extend Due Dates.
Created attachment 183906 [details] [review] Bug 40332: Show tools sidebar category for batch extend due dates permission To test: 1 - have or create a user with the permissions batch_extend_due_dates edit_quotes but no other Tools 2 - log into koha as that user, go to Tools module, confirm both Batch Extend Due Dates and Quote Editor are available from the Tools module home page 3 - Click into either available tool, confirm the sidebar menu contains the category Additional Tools and a link to Quote Editor, but nothing else 4 - add the edit_notices permission to your user 5 - reload your page from step 3, confirm the sidebar menu now also contains the Patrons & Circulation category with both Notices & Slips and Batch Extend Due Dates. 6 - apply patch, restart services, reload page, confirm nothing has changed 7 - remove the edit_notices permission from your user 8 - reload your page from step 3, confirm the sidebar menu now contains the Patrons & Circulation category with only Batch Extend Due Dates. Signed-off-by: David Flater <flaterdavid@gmail.com>
Created attachment 183998 [details] [review] Bug 40332: Show tools sidebar category for batch extend due dates permission To test: 1 - have or create a user with the permissions batch_extend_due_dates edit_quotes but no other Tools 2 - log into koha as that user, go to Tools module, confirm both Batch Extend Due Dates and Quote Editor are available from the Tools module home page 3 - Click into either available tool, confirm the sidebar menu contains the category Additional Tools and a link to Quote Editor, but nothing else 4 - add the edit_notices permission to your user 5 - reload your page from step 3, confirm the sidebar menu now also contains the Patrons & Circulation category with both Notices & Slips and Batch Extend Due Dates. 6 - apply patch, restart services, reload page, confirm nothing has changed 7 - remove the edit_notices permission from your user 8 - reload your page from step 3, confirm the sidebar menu now contains the Patrons & Circulation category with only Batch Extend Due Dates. Signed-off-by: David Flater <flaterdavid@gmail.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Nice catch, thanks Andrew! Passing QA
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x