Bug 40332 - Tools menu sidebar category not shown for users with batch_extend_due_dates only
Summary: Tools menu sidebar category not shown for users with batch_extend_due_dates only
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Andrew Fuerste-Henry
QA Contact: Emily Lamancusa (emlam)
URL:
Keywords:
Depends on:
Blocks: 36135
  Show dependency treegraph
 
Reported: 2025-07-09 12:14 UTC by Andrew Fuerste-Henry
Modified: 2025-07-24 08:20 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.02
Circulation function:


Attachments
Bug 40332: Show tools sidebar category for batch extend due dates permission (2.74 KB, patch)
2025-07-09 13:31 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 40332: Show tools sidebar category for batch extend due dates permission (2.79 KB, patch)
2025-07-09 19:32 UTC, David Flater
Details | Diff | Splinter Review
Bug 40332: Show tools sidebar category for batch extend due dates permission (2.86 KB, patch)
2025-07-11 13:19 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2025-07-09 12:14:24 UTC
In the Tools module, the sidebar menu is broken into categories Patrons & Circulation and Additional Tools. In theory, a category is shown if the user has at least one permission within that category. However, there's at least one permission that didn't get properly added to the bit of the page template that controls display of the category.

To reproduce:
1 - have or create a user with the permissions batch_extend_due_dates edit_quotes but no other Tools
2 - log into koha as that user, go to Tools module, confirm both Batch Extend Due Dates and Quote Editor are available from the Tools module home page
3 - Click into either available tool, confirm the sidebar menu contains the category Additional Tools and a link to Quote Editor, but nothing else
4 - add the edit_notices permission to your user
5 - reload your page from step 3, confirm the sidebar menu now also contains the Patrons & Circulation category with both Notices & Slips and Batch Extend Due Dates.
Comment 1 Andrew Fuerste-Henry 2025-07-09 12:37:18 UTC
After reviewing the template, it looks like batch_extend_due_dates is the only one that's been missed at the category level, so this is really small.
Comment 2 Andrew Fuerste-Henry 2025-07-09 13:31:57 UTC
Created attachment 183891 [details] [review]
Bug 40332: Show tools sidebar category for batch extend due dates permission

To test:
1 - have or create a user with the permissions batch_extend_due_dates edit_quotes but no other Tools
2 - log into koha as that user, go to Tools module, confirm both Batch Extend Due Dates and Quote Editor are available from the Tools module home page
3 - Click into either available tool, confirm the sidebar menu contains the category Additional Tools and a link to Quote Editor, but nothing else
4 - add the edit_notices permission to your user
5 - reload your page from step 3, confirm the sidebar menu now also contains the Patrons & Circulation category with both Notices & Slips and Batch Extend Due Dates.
6 - apply patch, restart services, reload page, confirm nothing has changed
7 - remove the edit_notices permission from your user
8 - reload your page from step 3, confirm the sidebar menu now contains the Patrons & Circulation category with only Batch Extend Due Dates.
Comment 3 David Flater 2025-07-09 19:32:29 UTC
Created attachment 183906 [details] [review]
Bug 40332: Show tools sidebar category for batch extend due dates permission

To test:
1 - have or create a user with the permissions batch_extend_due_dates edit_quotes but no other Tools
2 - log into koha as that user, go to Tools module, confirm both Batch Extend Due Dates and Quote Editor are available from the Tools module home page
3 - Click into either available tool, confirm the sidebar menu contains the category Additional Tools and a link to Quote Editor, but nothing else
4 - add the edit_notices permission to your user
5 - reload your page from step 3, confirm the sidebar menu now also contains the Patrons & Circulation category with both Notices & Slips and Batch Extend Due Dates.
6 - apply patch, restart services, reload page, confirm nothing has changed
7 - remove the edit_notices permission from your user
8 - reload your page from step 3, confirm the sidebar menu now contains the Patrons & Circulation category with only Batch Extend Due Dates.

Signed-off-by: David Flater <flaterdavid@gmail.com>
Comment 4 Emily Lamancusa (emlam) 2025-07-11 13:19:30 UTC
Created attachment 183998 [details] [review]
Bug 40332: Show tools sidebar category for batch extend due dates permission

To test:
1 - have or create a user with the permissions batch_extend_due_dates edit_quotes but no other Tools
2 - log into koha as that user, go to Tools module, confirm both Batch Extend Due Dates and Quote Editor are available from the Tools module home page
3 - Click into either available tool, confirm the sidebar menu contains the category Additional Tools and a link to Quote Editor, but nothing else
4 - add the edit_notices permission to your user
5 - reload your page from step 3, confirm the sidebar menu now also contains the Patrons & Circulation category with both Notices & Slips and Batch Extend Due Dates.
6 - apply patch, restart services, reload page, confirm nothing has changed
7 - remove the edit_notices permission from your user
8 - reload your page from step 3, confirm the sidebar menu now contains the Patrons & Circulation category with only Batch Extend Due Dates.

Signed-off-by: David Flater <flaterdavid@gmail.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 5 Emily Lamancusa (emlam) 2025-07-11 13:20:07 UTC
Nice catch, thanks Andrew! Passing QA
Comment 6 Lucas Gass (lukeg) 2025-07-11 21:29:56 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 7 Paul Derscheid 2025-07-24 08:20:42 UTC
Nice work everyone!

Pushed to 25.05.x