Bug 40338 - Tidy the whole codebase
Summary: Tidy the whole codebase
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: 24.11
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-07-10 08:33 UTC by Martin Renvoize (ashimema)
Modified: 2025-07-10 11:07 UTC (History)
16 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This is an improvement to the internals of Koha, which will not cause any changes to library workflows. Release notes for developers: Most of the codebase is now tidy. .pm, .pl, .t, .tt, .inc, .vue, and .js files are, and will continue to be, kept tidy! Update your ktd to get: The new images with a pre-commit Git hook, which will be installed at ktd startup. The updated QA script. A Prettier plugin for tidying Template Toolkit files: https://gitlab.com/koha-community/prettier-plugin-template-toolkit For new patches you don’t need to do anything special: The pre-commit hook will automatically tidy files when you commit your changes. The QA script will check that your commits contain tidy versions of the files. There are two new scripts available for developers: misc/devel/tidy.pl - Used to tidy files. misc/devel/auto_rebase.pl - Automatically attempts to rebase your patches.
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2025-07-10 08:33:22 UTC
We tidied our whole codebase in 25.05.. but this makes backports to the maintenance branches an ongoing challenge.

This bug serves to independently backport the tidy to the 24.11.x branch to hopefully make future maintenance simpler.

+++ This bug was initially created as a clone of Bug #38664 +++
Comment 1 Paul Derscheid 2025-07-10 08:38:08 UTC
Makes sense.

The queue for 24.11 is very full and backports are often time consuming.
Comment 2 Martin Renvoize (ashimema) 2025-07-10 11:07:41 UTC
I'll be pushing a branch up shortly.. it wasn't too too terrible.. but it'll be worthwhile getting some testing on some focus area's.