03:28:19 koha_1 | substr outside of string at /kohadevbox/koha/Koha/Edifact/Segment.pm line 101. 03:28:19 koha_1 | Use of uninitialized value $seg in substitution (s///) at /kohadevbox/koha/Koha/Edifact/Segment.pm line 103. 03:28:19 koha_1 | Use of uninitialized value $seg in split at /kohadevbox/koha/Koha/Edifact/Segment.pm line 104.
Created attachment 184374 [details] [review] Bug 40386: Remove warnings from EDI when running tests This patch fixes several warnings that occur when running Edifact tests: 1. Changed `my $self = ()` to `my $self = {}` in Koha::Edifact constructor to properly initialize as hashref instead of empty list 2. Added null/empty checks in Koha::Edifact::Segment::_parse_seg() to prevent warnings when processing undefined or empty segments 3. Added null/empty checks in Koha::Edifact::Segment::_get_elements() to handle undefined segments gracefully 4. Added Test::NoWarnings to t/Edifact.t to catch any remaining warnings These changes eliminate "Use of uninitialized value" warnings and ensure clean test runs without affecting EDI functionality. Test plan: 1. Run prove t/Edifact.t and verify no warnings are displayed 2. Test EDI message processing to ensure no regression
Created attachment 184549 [details] [review] Bug 40386: Remove warnings from EDI when running tests This patch fixes several warnings that occur when running Edifact tests: 1. Changed `my $self = ()` to `my $self = {}` in Koha::Edifact constructor to properly initialize as hashref instead of empty list 2. Added null/empty checks in Koha::Edifact::Segment::_parse_seg() to prevent warnings when processing undefined or empty segments 3. Added null/empty checks in Koha::Edifact::Segment::_get_elements() to handle undefined segments gracefully 4. Added Test::NoWarnings to t/Edifact.t to catch any remaining warnings These changes eliminate "Use of uninitialized value" warnings and ensure clean test runs without affecting EDI functionality. Test plan: 1. Run prove t/Edifact.t and verify no warnings are displayed 2. Test EDI message processing to ensure no regression Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x