Bug 40389 - t/dummy.t is useless
Summary: t/dummy.t is useless
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-07-15 12:59 UTC by Jonathan Druart
Modified: 2025-07-24 08:21 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.02
Circulation function:


Attachments
Bug 40389: Remove t/dummy.t (1.06 KB, patch)
2025-07-15 13:01 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40389: Remove t/dummy.t (1.11 KB, patch)
2025-07-18 07:36 UTC, David Nind
Details | Diff | Splinter Review
Bug 40389: Remove t/dummy.t (1.20 KB, patch)
2025-07-18 09:09 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-07-15 12:59:06 UTC

    
Comment 1 Jonathan Druart 2025-07-15 13:00:03 UTC
commit a5a419616ddaf81e2a9dc6a87ab92bcf2b336fde
Date:   Tue Aug 28 01:50:55 2007 +0100

    Disable tests

@ t/dummy.t:1 @
+# Dummy test until Test::Harness or similar
+# is used by the other tests to check deps.
+print "1..1\nok 1\n";



Then

commit 7f019954460801a5fe480640cf2674dbcca9f625
Date:   Fri Dec 7 17:15:22 2007 -0600

    installer (part 3): enabled 'make test'

 
-   # disable tests
-   'test' => {TESTS => 't/dummy.t'},
Comment 2 Jonathan Druart 2025-07-15 13:01:10 UTC
Created attachment 184089 [details] [review]
Bug 40389: Remove t/dummy.t

This file should have been removed years ago.

See the history:

commit a5a419616ddaf81e2a9dc6a87ab92bcf2b336fde
Date:   Tue Aug 28 01:50:55 2007 +0100

    Disable tests

@ t/dummy.t:1 @
+# Dummy test until Test::Harness or similar
+# is used by the other tests to check deps.
+print "1..1\nok 1\n";

Then

commit 7f019954460801a5fe480640cf2674dbcca9f625
Date:   Fri Dec 7 17:15:22 2007 -0600

    installer (part 3): enabled 'make test'

-   # disable tests
-   'test' => {TESTS => 't/dummy.t'},
Comment 3 David Nind 2025-07-18 07:36:22 UTC
Created attachment 184290 [details] [review]
Bug 40389: Remove t/dummy.t

This file should have been removed years ago.

See the history:

commit a5a419616ddaf81e2a9dc6a87ab92bcf2b336fde
Date:   Tue Aug 28 01:50:55 2007 +0100

    Disable tests

@ t/dummy.t:1 @
+# Dummy test until Test::Harness or similar
+# is used by the other tests to check deps.
+print "1..1\nok 1\n";

Then

commit 7f019954460801a5fe480640cf2674dbcca9f625
Date:   Fri Dec 7 17:15:22 2007 -0600

    installer (part 3): enabled 'make test'

-   # disable tests
-   'test' => {TESTS => 't/dummy.t'},

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Marcel de Rooy 2025-07-18 09:09:18 UTC
Created attachment 184307 [details] [review]
Bug 40389: Remove t/dummy.t

This file should have been removed years ago.

See the history:

commit a5a419616ddaf81e2a9dc6a87ab92bcf2b336fde
Date:   Tue Aug 28 01:50:55 2007 +0100

    Disable tests

@ t/dummy.t:1 @
+# Dummy test until Test::Harness or similar
+# is used by the other tests to check deps.
+print "1..1\nok 1\n";

Then

commit 7f019954460801a5fe480640cf2674dbcca9f625
Date:   Fri Dec 7 17:15:22 2007 -0600

    installer (part 3): enabled 'make test'

-   # disable tests
-   'test' => {TESTS => 't/dummy.t'},

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Lucas Gass (lukeg) 2025-07-18 17:12:31 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 6 Paul Derscheid 2025-07-24 08:21:23 UTC
Nice work everyone!

Pushed to 25.05.x