Bug 40470 - REPORT_GROUP authorized value cannot be numeric
Summary: REPORT_GROUP authorized value cannot be numeric
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-07-22 20:43 UTC by George Williams (NEKLS)
Modified: 2025-10-29 09:09 UTC (History)
4 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.05
Circulation function:


Attachments
Bug 40470: Fix filtering by REPORT_GROUP when auth val is numeric (1.42 KB, patch)
2025-07-23 09:07 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40470: Fix filtering by REPORT_GROUP when auth val is numeric (1.45 KB, patch)
2025-07-23 14:35 UTC, OpenFifth Sandboxes
Details | Diff | Splinter Review
Bug 40470: Fix filtering by REPORT_GROUP when auth val is numeric (1.55 KB, patch)
2025-10-17 08:46 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description George Williams (NEKLS) 2025-07-22 20:43:11 UTC
If you create a REPORT_GROUP authorized value with a purely numeric value, the tabs on guided_reports.pl will not filter based on that value.

REPORT_GROUP authorized values with alphabetic and numeric values do work - it's only purely numeric values that cause the tab filtering to fail.
Comment 1 Jonathan Druart 2025-07-23 09:07:32 UTC
Created attachment 184533 [details] [review]
Bug 40470: Fix filtering by REPORT_GROUP when auth val is numeric

When the authorised value of a REPORT_GROUP is numeric the filtering
does not work.

Test plan:
Create a new REPORT_GROUP av "123" (the description can be alphanumeric)
Create a new report and assign it to this new group
Confirm that with this patch the filtering works when the "123" tab is
selected
Comment 2 OpenFifth Sandboxes 2025-07-23 14:35:49 UTC
Created attachment 184557 [details] [review]
Bug 40470: Fix filtering by REPORT_GROUP when auth val is numeric

When the authorised value of a REPORT_GROUP is numeric the filtering
does not work.

Test plan:
Create a new REPORT_GROUP av "123" (the description can be alphanumeric)
Create a new report and assign it to this new group
Confirm that with this patch the filtering works when the "123" tab is
selected

Signed-off-by: George <george@nekls.org>
Comment 3 George Williams (NEKLS) 2025-07-23 14:36:51 UTC
Works according to test plan.  Thanks.
Comment 4 Marcel de Rooy 2025-10-17 08:46:01 UTC
Created attachment 188051 [details] [review]
Bug 40470: Fix filtering by REPORT_GROUP when auth val is numeric

When the authorised value of a REPORT_GROUP is numeric the filtering
does not work.

Test plan:
Create a new REPORT_GROUP av "123" (the description can be alphanumeric)
Create a new report and assign it to this new group
Confirm that with this patch the filtering works when the "123" tab is
selected

Signed-off-by: George <george@nekls.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Lucas Gass (lukeg) 2025-10-20 16:14:19 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 6 Paul Derscheid 2025-10-29 09:09:47 UTC
Nice work everyone!

Pushed to 25.05.x