Bug 40483 - Searching vendors by Alias no longer works
Summary: Searching vendors by Alias no longer works
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Laura Escamilla
URL:
Keywords: regression
Depends on:
Blocks: 38201
  Show dependency treegraph
 
Reported: 2025-07-23 17:40 UTC by Sara Brown
Modified: 2025-08-20 18:58 UTC (History)
4 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 40483: Restore search vendors by alias (2.59 KB, patch)
2025-07-24 08:03 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40483: Restore search vendors by alias (2.64 KB, patch)
2025-07-29 04:57 UTC, David Nind
Details | Diff | Splinter Review
Bug 40483: Restore search vendors by alias (2.70 KB, patch)
2025-08-16 00:01 UTC, Laura Escamilla
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Sara Brown 2025-07-23 17:40:45 UTC
In 25.05, searching for vendors by an alias no longer works. To replicate:
-Find an existing vendor, and add an Alias to their details
-Search using the alias from the main Acquisitions page - note that there are no results
-Search using the green 'Vendor search' bar - note that there are no results

Marking as a regression since searching using either of these methods works in 24.11.
Comment 1 Jonathan Druart 2025-07-24 08:03:39 UTC
Created attachment 184577 [details] [review]
Bug 40483: Restore search vendors by alias

Prior to bug 38010 we were able to search vendors by alias.

This patch restores it by moving the filter to kohaTable's "default_filters" to allow to pass a more complex condition

Test plan:
Create several vendors, some with aliases
Confirm that searching by alias return the vendors
Confirm that refining the search (using the table's global search) works
as expected
Comment 2 David Nind 2025-07-29 04:57:09 UTC
Created attachment 184778 [details] [review]
Bug 40483: Restore search vendors by alias

Prior to bug 38010 we were able to search vendors by alias.

This patch restores it by moving the filter to kohaTable's "default_filters" to allow to pass a more complex condition

Test plan:
Create several vendors, some with aliases
Confirm that searching by alias return the vendors
Confirm that refining the search (using the table's global search) works
as expected

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Laura Escamilla 2025-08-16 00:01:52 UTC
Created attachment 185486 [details] [review]
Bug 40483: Restore search vendors by alias

Prior to bug 38010 we were able to search vendors by alias.

This patch restores it by moving the filter to kohaTable's "default_filters" to allow to pass a more complex condition

Test plan:
Create several vendors, some with aliases
Confirm that searching by alias return the vendors
Confirm that refining the search (using the table's global search) works
as expected

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 4 Lucas Gass (lukeg) 2025-08-20 18:56:34 UTC
Nice work everyone!

Pushed to main for 25.11