Bug 40488 - "Public lists" breadcrumb link doesn't work when editing public list in staff interface
Summary: "Public lists" breadcrumb link doesn't work when editing public list in staff...
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Lists (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Owen Leonard
QA Contact: David Cook
URL:
Keywords: release-notes-needed
Depends on:
Blocks:
 
Reported: 2025-07-24 02:34 UTC by David Cook
Modified: 2025-07-25 20:43 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 40488: Fix breadcrumb link to public lists when editing a list in the staff interface (2.02 KB, patch)
2025-07-24 14:16 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40488: Fix breadcrumb link to public lists when editing a list in the staff interface (2.07 KB, patch)
2025-07-24 21:19 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 40488: Fix breadcrumb link to public lists when editing a list in the staff interface (2.12 KB, patch)
2025-07-25 03:38 UTC, David Cook
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2025-07-24 02:34:49 UTC
If you go to http://localhost:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=edit_form&shelfnumber=1&referer=view and try to click "Public lists" in the breadcrumbs, it just takes you to http://localhost:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=edit_form&shelfnumber=1&referer=view# 

Note the hash on the end of the URL after clicking the breadcrumb.

Note that this only affects public lists. Private/Your lists works.
Comment 1 Owen Leonard 2025-07-24 14:16:12 UTC
Created attachment 184594 [details] [review]
Bug 40488: Fix breadcrumb link to public lists when editing a list in the staff interface

This patch revises the breadcrumbs in the staff interface lists template
so that the correct link is shown when editing or viewing a public list.

To test, apply the patch and go to Lists in the staff interface.

- Create a public list
- Go to the list of public lists
- Click to view your newly created public list
- The breadcrumb menu should show Lists -> Public lists -> Contents of
  [list name]
- The link to public lists should work correctly.
- Perform the same check when editing your public list.
- Check the viewing and editing of a private list to make sure no
  breadcrumb errors were introduced.

Sponsored-by: Athens County Public Libraries
Comment 2 Roman Dolny 2025-07-24 21:19:16 UTC
Created attachment 184609 [details] [review]
Bug 40488: Fix breadcrumb link to public lists when editing a list in the staff interface

This patch revises the breadcrumbs in the staff interface lists template
so that the correct link is shown when editing or viewing a public list.

To test, apply the patch and go to Lists in the staff interface.

- Create a public list
- Go to the list of public lists
- Click to view your newly created public list
- The breadcrumb menu should show Lists -> Public lists -> Contents of
  [list name]
- The link to public lists should work correctly.
- Perform the same check when editing your public list.
- Check the viewing and editing of a private list to make sure no
  breadcrumb errors were introduced.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 David Cook 2025-07-25 03:38:59 UTC
Created attachment 184611 [details] [review]
Bug 40488: Fix breadcrumb link to public lists when editing a list in the staff interface

This patch revises the breadcrumbs in the staff interface lists template
so that the correct link is shown when editing or viewing a public list.

To test, apply the patch and go to Lists in the staff interface.

- Create a public list
- Go to the list of public lists
- Click to view your newly created public list
- The breadcrumb menu should show Lists -> Public lists -> Contents of
  [list name]
- The link to public lists should work correctly.
- Perform the same check when editing your public list.
- Check the viewing and editing of a private list to make sure no
  breadcrumb errors were introduced.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Comment 4 David Cook 2025-07-25 03:39:09 UTC
Thanks, Owen!
Comment 5 Lucas Gass (lukeg) 2025-07-25 20:40:44 UTC
Nice work everyone!

Pushed to main for 25.11