If you go to http://localhost:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=edit_form&shelfnumber=1&referer=view and try to click "Public lists" in the breadcrumbs, it just takes you to http://localhost:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=edit_form&shelfnumber=1&referer=view# Note the hash on the end of the URL after clicking the breadcrumb. Note that this only affects public lists. Private/Your lists works.
Created attachment 184594 [details] [review] Bug 40488: Fix breadcrumb link to public lists when editing a list in the staff interface This patch revises the breadcrumbs in the staff interface lists template so that the correct link is shown when editing or viewing a public list. To test, apply the patch and go to Lists in the staff interface. - Create a public list - Go to the list of public lists - Click to view your newly created public list - The breadcrumb menu should show Lists -> Public lists -> Contents of [list name] - The link to public lists should work correctly. - Perform the same check when editing your public list. - Check the viewing and editing of a private list to make sure no breadcrumb errors were introduced. Sponsored-by: Athens County Public Libraries
Created attachment 184609 [details] [review] Bug 40488: Fix breadcrumb link to public lists when editing a list in the staff interface This patch revises the breadcrumbs in the staff interface lists template so that the correct link is shown when editing or viewing a public list. To test, apply the patch and go to Lists in the staff interface. - Create a public list - Go to the list of public lists - Click to view your newly created public list - The breadcrumb menu should show Lists -> Public lists -> Contents of [list name] - The link to public lists should work correctly. - Perform the same check when editing your public list. - Check the viewing and editing of a private list to make sure no breadcrumb errors were introduced. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 184611 [details] [review] Bug 40488: Fix breadcrumb link to public lists when editing a list in the staff interface This patch revises the breadcrumbs in the staff interface lists template so that the correct link is shown when editing or viewing a public list. To test, apply the patch and go to Lists in the staff interface. - Create a public list - Go to the list of public lists - Click to view your newly created public list - The breadcrumb menu should show Lists -> Public lists -> Contents of [list name] - The link to public lists should work correctly. - Perform the same check when editing your public list. - Check the viewing and editing of a private list to make sure no breadcrumb errors were introduced. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: David Cook <dcook@prosentient.com.au>
Thanks, Owen!
Nice work everyone! Pushed to main for 25.11