The item add form uses the wrong template variable to set the maxlength attribute on a text input field.
Created attachment 184598 [details] [review] Bug 40497: Item add form does not respect framework maxlength setting This patch corrects the template variable which populates the maxlenth attribute on text fields in the add/edit item form. To test, apply the patch and go Administratoin -> MARC bibliographic frameworks -> (framework) -> Tag 952 -> Edit subfields. - Click the "p" tab and set the "Max length" field to "20" - Save the framework and go to Cataloging. - Locate a bibliographic record that uses the framework you edited. - Add or edit an item on that bibliographic record. - Check the "Barcode" field. The input tag should limit your entry to 20 characters. Sponsored-by: Athens County Public Libraries
Created attachment 184776 [details] [review] Bug 40497: Item add form does not respect framework maxlength setting This patch corrects the template variable which populates the maxlenth attribute on text fields in the add/edit item form. To test, apply the patch and go Administratoin -> MARC bibliographic frameworks -> (framework) -> Tag 952 -> Edit subfields. - Click the "p" tab and set the "Max length" field to "20" - Save the framework and go to Cataloging. - Locate a bibliographic record that uses the framework you edited. - Add or edit an item on that bibliographic record. - Check the "Barcode" field. The input tag should limit your entry to 20 characters. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com>
I cannot recreate the issue before the patch, if I alter the maxlength of a field it is respected
Created attachment 185894 [details] [review] Bug 40497: Item add form does not respect framework maxlength setting This patch corrects the template variable which populates the maxlenth attribute on text fields in the add/edit item form. To test, apply the patch and go Administratoin -> MARC bibliographic frameworks -> (framework) -> Tag 952 -> Edit subfields. - Click the "p" tab and set the "Max length" field to "20" - Save the framework and go to Cataloging. - Locate a bibliographic record that uses the framework you edited. - Add or edit an item on that bibliographic record. - Check the "Barcode" field. The input tag should limit your entry to 20 characters. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work everyone! Pushed to main for 25.11