To reproduce 1. Set <enable_plugins> in koha-conf.xml to 0 2. Do a batch record modification, or some task that would set off a background job 3. Click to view the job 4. Internal server error
Oops! This is one of the reasons I don't love method chaining.
Created attachment 184854 [details] [review] Bug 40547: Background jobs should appear even when plugins disabled This change fixes the background jobs so that the list page loads even when plugins are disabled. Test plan: 0. Apply the patch 1. Download https://github.com/HKS3/koha-normalize-marc2db/releases/download/v0.91/Koha.Plugin.HKS3.NormalizeMARC2DB-0.91.kpz 2. Upload plugin into KTD 3. Click "Run tool" for plugin 4. Go to http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl 5. Note that you see a pretty "Type" 6. Go to /etc/koha/sites/kohadev/koha-conf.xml and turn enable_plugins to 0 7. sudo koha-plack --restart kohadev 8. Go to http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl 9. Note it now says "Unknown job type 'plugin_marc2db_normalizeall' 10. Celebrate as this is preferable to a 500 error
Created attachment 184918 [details] [review] Bug 40547: Background jobs should appear even when plugins disabled This change fixes the background jobs so that the list page loads even when plugins are disabled. Test plan: 0. Apply the patch 1. Download https://github.com/HKS3/koha-normalize-marc2db/releases/download/v0.91/Koha.Plugin.HKS3.NormalizeMARC2DB-0.91.kpz 2. Upload plugin into KTD 3. Click "Run tool" for plugin 4. Go to http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl 5. Note that you see a pretty "Type" 6. Go to /etc/koha/sites/kohadev/koha-conf.xml and turn enable_plugins to 0 7. sudo koha-plack --restart kohadev 8. Go to http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl 9. Note it now says "Unknown job type 'plugin_marc2db_normalizeall' 10. Celebrate as this is preferable to a 500 error Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Created attachment 184931 [details] [review] Bug 40547: Background jobs should appear even when plugins disabled This change fixes the background jobs so that the list page loads even when plugins are disabled. Test plan: 0. Apply the patch 1. Download https://github.com/HKS3/koha-normalize-marc2db/releases/download/v0.91/Koha.Plugin.HKS3.NormalizeMARC2DB-0.91.kpz 2. Upload plugin into KTD 3. Click "Run tool" for plugin 4. Go to http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl 5. Note that you see a pretty "Type" 6. Go to /etc/koha/sites/kohadev/koha-conf.xml and turn enable_plugins to 0 7. sudo koha-plack --restart kohadev 8. Go to http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl 9. Note it now says "Unknown job type 'plugin_marc2db_normalizeall' 10. Celebrate as this is preferable to a 500 error Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Nice work everyone! Pushed to main for 25.11