Bug 40586 - opac-user, holds-table.inc: Include on order status when item.notforloan < 0
Summary: opac-user, holds-table.inc: Include on order status when item.notforloan < 0
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-08-04 12:07 UTC by Marcel de Rooy
Modified: 2025-09-25 16:30 UTC (History)
4 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.04
Circulation function:


Attachments
Bug 40586: Show negative notforloan status in holds table on opac-user (1.63 KB, patch)
2025-08-04 12:40 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 40586: Show negative notforloan status in holds table on opac-user (1.89 KB, patch)
2025-08-04 12:53 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 40586: Show negative notforloan status in holds table on opac-user (1.91 KB, patch)
2025-08-27 11:41 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40586: (QA follow-up) Add comment about effective notforloan status (1.48 KB, patch)
2025-09-17 12:57 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 40586: Show negative notforloan status in holds table on opac-user (1.98 KB, patch)
2025-09-22 12:48 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40586: (QA follow-up) Add comment about effective notforloan status (1.52 KB, patch)
2025-09-22 12:48 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2025-08-04 12:07:29 UTC
An item level hold on an item that has a negative notforloan status (on order or another custom negative notforloan status probably related to acquisition and related processing) is just marked "Pending" on the opac-user page. Would be more clear to include "On order" or a description from authorised values.
Comment 1 Marcel de Rooy 2025-08-04 12:40:19 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2025-08-04 12:53:19 UTC
Created attachment 185098 [details] [review]
Bug 40586: Show negative notforloan status in holds table on opac-user

If an item is on order, it may take a while before becoming available.
Showing that too on the opac-user page is helpful for the user and
may reduce questions.

Test plan:
Pick an item and set notforloan to On order (-1) or another custom
negative notforloan status.
Put an item level hold on that item.
Go to the OPAC user page of that patron. Verify that the AV description
is added now to the status column of the holds table.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Owen Leonard 2025-08-27 11:41:16 UTC
Created attachment 185808 [details] [review]
Bug 40586: Show negative notforloan status in holds table on opac-user

If an item is on order, it may take a while before becoming available.
Showing that too on the opac-user page is helpful for the user and
may reduce questions.

Test plan:
Pick an item and set notforloan to On order (-1) or another custom
negative notforloan status.
Put an item level hold on that item.
Go to the OPAC user page of that patron. Verify that the AV description
is added now to the status column of the holds table.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Jonathan Druart 2025-09-16 13:47:12 UTC
Shouldn't we use Koha::Item->effective_not_for_loan_status instead?
Comment 5 Marcel de Rooy 2025-09-17 12:57:07 UTC
(In reply to Jonathan Druart from comment #4)
> Shouldn't we use Koha::Item->effective_not_for_loan_status instead?

Good question. Dont think so since we are just testing < 0. And the itemtype notforloan is just 0 or 1. Will add a comment for it.
Comment 6 Marcel de Rooy 2025-09-17 12:57:21 UTC
Created attachment 186533 [details] [review]
Bug 40586: (QA follow-up) Add comment about effective notforloan status

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Jonathan Druart 2025-09-22 12:48:07 UTC
Created attachment 186686 [details] [review]
Bug 40586: Show negative notforloan status in holds table on opac-user

If an item is on order, it may take a while before becoming available.
Showing that too on the opac-user page is helpful for the user and
may reduce questions.

Test plan:
Pick an item and set notforloan to On order (-1) or another custom
negative notforloan status.
Put an item level hold on that item.
Go to the OPAC user page of that patron. Verify that the AV description
is added now to the status column of the holds table.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Jonathan Druart 2025-09-22 12:48:09 UTC
Created attachment 186687 [details] [review]
Bug 40586: (QA follow-up) Add comment about effective notforloan status

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Lucas Gass (lukeg) 2025-09-23 22:24:53 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 10 Paul Derscheid 2025-09-25 16:30:14 UTC
Nice work everyone!

Pushed to 25.05.x