An item level hold on an item that has a negative notforloan status (on order or another custom negative notforloan status probably related to acquisition and related processing) is just marked "Pending" on the opac-user page. Would be more clear to include "On order" or a description from authorised values.
Created attachment 185097 [details] [review] Bug 40586: Show negative notforloan status in holds table on opac-user If an item is on order, it may take a while before becoming available. Showing that too on the opac-user page is helpful for the user and may reduce questions. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 185098 [details] [review] Bug 40586: Show negative notforloan status in holds table on opac-user If an item is on order, it may take a while before becoming available. Showing that too on the opac-user page is helpful for the user and may reduce questions. Test plan: Pick an item and set notforloan to On order (-1) or another custom negative notforloan status. Put an item level hold on that item. Go to the OPAC user page of that patron. Verify that the AV description is added now to the status column of the holds table. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 185808 [details] [review] Bug 40586: Show negative notforloan status in holds table on opac-user If an item is on order, it may take a while before becoming available. Showing that too on the opac-user page is helpful for the user and may reduce questions. Test plan: Pick an item and set notforloan to On order (-1) or another custom negative notforloan status. Put an item level hold on that item. Go to the OPAC user page of that patron. Verify that the AV description is added now to the status column of the holds table. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Shouldn't we use Koha::Item->effective_not_for_loan_status instead?
(In reply to Jonathan Druart from comment #4) > Shouldn't we use Koha::Item->effective_not_for_loan_status instead? Good question. Dont think so since we are just testing < 0. And the itemtype notforloan is just 0 or 1. Will add a comment for it.
Created attachment 186533 [details] [review] Bug 40586: (QA follow-up) Add comment about effective notforloan status Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 186686 [details] [review] Bug 40586: Show negative notforloan status in holds table on opac-user If an item is on order, it may take a while before becoming available. Showing that too on the opac-user page is helpful for the user and may reduce questions. Test plan: Pick an item and set notforloan to On order (-1) or another custom negative notforloan status. Put an item level hold on that item. Go to the OPAC user page of that patron. Verify that the AV description is added now to the status column of the holds table. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 186687 [details] [review] Bug 40586: (QA follow-up) Add comment about effective notforloan status Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x