Looking at [lang]-opac-bootstrap.po I see a lot of instances of repeated %s %s %s indicating opportunities to improve the markup structure to ease the translation process. This patch will tackle a batch of include files: koha-tmpl/intranet-tmpl/prog/en/includes/item-status.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/biblio-title-head.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/biblio-title.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/date-format.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
(In reply to Owen Leonard from comment #0) > koha-tmpl/intranet-tmpl/prog/en/includes/item-status.inc Correction, not this one!
Created attachment 185510 [details] [review] Bug 40610: Update OPAC templates to improve ease of translation This patch updates the markup structure of some OPAC include files in order to make the translation process easier. To test, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > gulp po:update --lang fr-FR > perl misc/translator/translate update fr-FR - Open the corresponding .po file for the strings pulled from the include file and locate the updated strings. - misc/translator/po/fr-FR-messages.po - opac-tmpl/bootstrap/en/includes/biblio-title.inc lines 4 & 5 - opac-tmpl/bootstrap/en/includes/date-format.inc lines 4, 6, 8 - opac-tmpl/bootstrap/en/includes/holds-table.inc lines 132 & 135 - opac-tmpl/bootstrap/en/includes/masthead.inc line 498 - misc/translator/po/fr-FR/fr-FR-opac-bootstrap.po - opac-tmpl/bootstrap/en/includes/biblio-title-head.inc - opac-tmpl/bootstrap/en/includes/holds-table.inc line 129 & 141 - Edit the "msgstr" string however you want (it's just for testing). - Remove the "fuzzy, " text if it's there. - Install the updated translation: > perl mis/translator/translate install fr-FR - Switch to your translated language in the OPAC. - Confirm that the strings you translated show up correctly on these pages: - The page title when viewing a bibliographic record detail page for a record without a title. - On a user summary page, under the hold tab: - A hold that is waiting - A hold that is in transit - In Administration -> Identity providers define a new identity provider (it doesn't have to be functional). - In the OPAC, test that the "Log in with [identity provider]" link is correct in each of the three login forms: - The modal triggered from the link in the header - The form in the right-hand sidebar - The form you see if you navigate directly to a user-related page e.g. /cgi-bin/koha/opac-user.pl - The changes to date-format.inc are only visible if JS is turned off because Flatpickr hides the format hint when it loads. Sponsored-by: Athens County Public Libraries