Bug 40622 - Bug 38233 not properly applied to 24.11.x+
Summary: Bug 38233 not properly applied to 24.11.x+
Status: ASSIGNED
Alias: None
Product: Koha
Classification: Unclassified
Component: Web services (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: David Cook
QA Contact: Testopia
URL:
Keywords:
Depends on: 38233 31224
Blocks:
  Show dependency treegraph
 
Reported: 2025-08-08 06:40 UTC by David Cook
Modified: 2025-08-08 07:06 UTC (History)
0 users

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40622: Add missing interface parameter (936 bytes, patch)
2025-08-08 07:06 UTC, David Cook
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2025-08-08 06:40:05 UTC
A close examination of the code in "C4/ILSDI/Services.pm" shows that only half the patch from bug 38233 was applied to 24.11.00.

It was properly backported to 24.05.06, so anyone upgrading from 24.05.06 to 24.11.00 would experience a regression.
Comment 1 David Cook 2025-08-08 06:42:04 UTC
I suppose I'll say the Version is Main and then it would need to be backported back to 24.11.x...
Comment 2 David Cook 2025-08-08 06:54:34 UTC
Since bug 38233 and bug 31224 went in around the same time, it looks like there was probably a merge conflict and the fix wasn't done correctly.
Comment 3 David Cook 2025-08-08 07:06:08 UTC
Created attachment 185262 [details] [review]
Bug 40622: Add missing interface parameter

This change adds the missing interface parameter which
Bug 38233 initially added.
Comment 4 David Cook 2025-08-08 07:06:36 UTC
Leaving as ASSIGNED as I'll need to come back to this with a test plan, verify it, and see about adding a unit test.