Bug 40691 - CCODE label not includes in case of 'wrong place' problem (and maybe others cases) into inventory.pl
Summary: CCODE label not includes in case of 'wrong place' problem (and maybe others c...
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Thibaud Guillot (thibaud_g)
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-08-22 09:09 UTC by Thibaud Guillot (thibaud_g)
Modified: 2025-10-10 13:49 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.04,24.11.10
Circulation function:


Attachments
Bug 40691: Add ccode label on inventory table (1.32 KB, patch)
2025-08-22 09:30 UTC, Thibaud Guillot (thibaud_g)
Details | Diff | Splinter Review
Bug 40691: Add ccode label on inventory table (1.37 KB, patch)
2025-08-23 16:14 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40691: Add ccode label on inventory table (1.47 KB, patch)
2025-08-29 07:08 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Thibaud Guillot (thibaud_g) 2025-08-22 09:09:07 UTC
Hello,

Just a quick fix: when you create an inventory of items and some items have “wrong place” problems, if they are associated with a collection code, the table will only display the code and not its label.
Comment 1 Thibaud Guillot (thibaud_g) 2025-08-22 09:30:08 UTC
Created attachment 185707 [details] [review]
Bug 40691: Add ccode label on inventory table

Test plan:

1) Perform an item inventory, be sure to have some items with problems
   :) like 'wrong place'
2) On table if item has 'wrong place' problem (maybe others cases ?) if
   it's linked to collection code just the AV code appears not the label
3) Apply this patch
4) Refresh page, normally that's okay now

Sponsored-by: BibLibre
Comment 2 Owen Leonard 2025-08-23 16:14:37 UTC
Created attachment 185726 [details] [review]
Bug 40691: Add ccode label on inventory table

Test plan:

1) Perform an item inventory, be sure to have some items with problems
   :) like 'wrong place'
2) On table if item has 'wrong place' problem (maybe others cases ?) if
   it's linked to collection code just the AV code appears not the label
3) Apply this patch
4) Refresh page, normally that's okay now

Sponsored-by: BibLibre
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Marcel de Rooy 2025-08-29 07:07:22 UTC
Filled Assignee ;)
Comment 4 Marcel de Rooy 2025-08-29 07:08:41 UTC
Created attachment 185874 [details] [review]
Bug 40691: Add ccode label on inventory table

Test plan:

1) Perform an item inventory, be sure to have some items with problems
   :) like 'wrong place'
2) On table if item has 'wrong place' problem (maybe others cases ?) if
   it's linked to collection code just the AV code appears not the label
3) Apply this patch
4) Refresh page, normally that's okay now

Sponsored-by: BibLibre
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Lucas Gass (lukeg) 2025-08-29 17:10:45 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 6 Paul Derscheid 2025-09-20 08:59:30 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 7 Fridolin Somers 2025-10-10 13:49:15 UTC
Pushed to 24.11.x for 24.11.10