In the course reserves module, if a patron account used for an instructor on a course has a preferred name different from the patron first name, the course will still display firstname instead of the preferred name.
https://github.com/Koha-Community/Koha/blob/5832521086b06c2221474791278ebd9b5bdb4049/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt#L117 We should use patron-title.inc here instead of grabbing firstname and surname directly.
Created attachment 185745 [details] [review] Bug 40699: Use patron-title for course reserve instructor To test: 1 - have or make a course reserves course with an instructor 2 - give your instructor a preferred name, confirm the course shows their firstname instead 3 - apply patch, reload page 4 - confirm course now shows their preferred_name instead 5 - edit the patron to remove the preferred name, confirm course shows first name again
Created attachment 186233 [details] [review] Bug 40699: Use patron-title for course reserve instructor To test: 1 - have or make a course reserves course with an instructor 2 - give your instructor a preferred name, confirm the course shows their firstname instead 3 - apply patch, reload page 4 - confirm course now shows their preferred_name instead 5 - edit the patron to remove the preferred name, confirm course shows first name again Signed-off-by: noah <noah@inlibro.com>
Created attachment 187472 [details] [review] Bug 40699: Correctly format patron everywhere in course reserves
Andrew, I found other places: * Create/edit a course * Course list Can you test and confirm it is needed as well please? :)
Note that I found several other places where they are not displayed correctly. I have fixed them on bug 32176. Please have a look :)
(In reply to Jonathan Druart from comment #5) > Andrew, I found other places: > * Create/edit a course > * Course list > > Can you test and confirm it is needed as well please? :) Those places both look good! They reminded me to go look at the OPAC, where we show firstname rather then preferred_name in both the course list and the course details. I'll aim to get back there and add those, but if you beat me to it and assign the bug to yourself, I'll be happy to sign off on it. Thanks!
(In reply to Andrew Fuerste-Henry from comment #7) > (In reply to Jonathan Druart from comment #5) > > Andrew, I found other places: > > * Create/edit a course > > * Course list > > > > Can you test and confirm it is needed as well please? :) > > Those places both look good! > They reminded me to go look at the OPAC, where we show firstname rather then > preferred_name in both the course list and the course details. > I'll aim to get back there and add those, but if you beat me to it and > assign the bug to yourself, I'll be happy to sign off on it. Thanks! I would suggest to do that on a separate bug report, because of commit 4dba088549d1add43cfd575ebdd3d21689c4a700 Bug 15699 - Course reserves instructors should be in form "Surname, Firstname" for sorting purposes and this code in ./opac-course-reserves.tt 63 ><span class="inst_surname">[% i.surname | html %]</span>[% IF i.firstname %]<span class="instr_separator">, </span><span class="instr_firstname">[% i.firstname | html %]</span>[% END %]</div
(In reply to Jonathan Druart from comment #8) > I would suggest to do that on a separate bug report Fair enough! setting this back to NSO