In bug 39184 we set EVAL_PERL and ABSOLUTE to 0, which is the default. RELATIVE also defaults to 0. For security we should probably specify that as well in case the default is changed somehow.
Created attachment 185848 [details] [review] Bug 40719: Explicitly disable off RELATIVE file paths for plugins for user-entered templates In bug 39184 we set EVAL_PERL and ABSOLUTE to 0, which is the default. RELATIVE also defaults to 0. For security we should probably specify that as well in case the default is changed somehow. Test Plan: 1) Apply this patch 2) Generate some notices 3) No change should be noted!
Created attachment 186179 [details] [review] Bug 40719: Explicitly disable off RELATIVE file paths for plugins for user-entered templates In bug 39184 we set EVAL_PERL and ABSOLUTE to 0, which is the default. RELATIVE also defaults to 0. For security we should probably specify that as well in case the default is changed somehow. Test Plan: 1) Apply this patch 2) Generate some notices 3) No change should be noted! Signed-off-by: noah <noah@inlibro.com>
Created attachment 186180 [details] [review] Bug 40719: Explicitly disable off RELATIVE file paths for plugins for user-entered templates In bug 39184 we set EVAL_PERL and ABSOLUTE to 0, which is the default. RELATIVE also defaults to 0. For security we should probably specify that as well in case the default is changed somehow. Test Plan: 1) Apply this patch 2) Generate some notices 3) No change should be noted! Signed-off-by: noah <noah@inlibro.com>
Created attachment 191538 [details] [review] Bug 40719: Explicitly disable off RELATIVE file paths for plugins for user-entered templates In bug 39184 we set EVAL_PERL and ABSOLUTE to 0, which is the default. RELATIVE also defaults to 0. For security we should probably specify that as well in case the default is changed somehow. Test Plan: 1) Apply this patch 2) Generate some notices 3) No change should be noted! Signed-off-by: noah <noah@inlibro.com> Signed-off-by: David Cook <dcook@prosentient.com.au>
Created attachment 191539 [details] [review] Bug 40719: Explicitly turn off RELATIVE for TemplateUtils This change explicitly turns off RELATIVE in Koha/TemplateUtils.pm Test plan (Koha/TemplateUtils.pm): 0. Apply the patch and koha-plack --restart kohadev 1. Go to http://localhost:8081/cgi-bin/koha/tools/letter.pl 2. Click "New notice" and choose "reports" 3. Add the following to the report: [% IF ( x == 1 ) %] One [% ELSE %] Two [% END %] 4. Go to http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl?phase=Use%20saved 5. Create a report like the following: SELECT biblionumber FROM biblio; 6. Click "Run with template" and choose the Reports template you made 7. Note that the output shows "Two" 8. Edit your Reports notice and include the following: [% INSERT ../etc/passwd %] 9. Re-run the report using "Run with template" 10. Note that the output shows the regular SQL results (ie template transform not successful) Signed-off-by: David Cook <dcook@prosentient.com.au>