To recreate: 1. Set TransfersBlockCirc to 'Don't block' 2. Check in some items not from your library to initiate a transfer. 3. See the modal pop-op, "Transfer to home library" 4. However, you cannot continue to scan the next item unless you first dismiss the modal.
This seems to have been lost with Bug 38842.
Created attachment 186051 [details] [review] Bug 40739: Use correct block/noblock class in item-transfer-modal To test: 1. Set TransfersBlockCirc to 'Don't block' 2. Check in some items not from your library to initiate a transfer. 3. See the modal pop-op, "Transfer to home library" 4. However, you cannot continue to scan the next item unless you first dismiss the modal. 5. APPLY PATCH 6. Try again, this time at step 4 the barcode input should have focus and you'll be able to scan the next item.
Setting to major because this can impact workflows quite badly.
This is definitely affecting our workflow for items returning home. Staff either have to click on the pop up or use "ALT + Y" to bypass the screen. Previously, we could bypass if we scanned another item.
Created attachment 186081 [details] [review] Bug 40739: Use correct block/noblock class in item-transfer-modal To test: 1. Set TransfersBlockCirc to 'Don't block' 2. Check in some items not from your library to initiate a transfer. 3. See the modal pop-op, "Transfer to home library" 4. However, you cannot continue to scan the next item unless you first dismiss the modal. 5. APPLY PATCH 6. Try again, this time at step 4 the barcode input should have focus and you'll be able to scan the next item.
Moving this straight to PQA; it's a trivial fix for a major regression. I think the cause was 8e7f5556 (bug 38714), though: [% IF Koha.Preference('TransfersBlockCirc') %] - <div id="item-transfer-modal" class="modal modal-lg block audio-alert-action" data-bs-backdrop="static" data-bs-keyboard="false"> + [% SET div_class='block' %] [% ELSE %] - <div id="item-transfer-modal" class="modal modal-lg noblock audio-alert-action"> + [% SET div_class='noblock' %] [% END %] + <div id="item-transfer-modal" class="modal modal-lg block audio-alert-action" [% IF Koha.Preference('TransfersBlockCirc') %]data-bs-backdrop="static" data-bs-keyboard="false"[% END %]>
Created attachment 186099 [details] [review] Bug 40739: Use correct block/noblock class in item-transfer-modal To test: 1. Set TransfersBlockCirc to 'Don't block' 2. Check in some items not from your library to initiate a transfer. 3. See the modal pop-op, "Transfer to home library" 4. However, you cannot continue to scan the next item unless you first dismiss the modal. 5. APPLY PATCH 6. Try again, this time at step 4 the barcode input should have focus and you'll be able to scan the next item. Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Thanks for catching that, Lucas! :)
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x
Bug 38714 not in 24.11.x