Bug 40743 - Unable to select the correct fund when paying invoices
Summary: Unable to select the correct fund when paying invoices
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low critical
Assignee: Laura Escamilla
QA Contact: Jonathan Druart
URL:
Keywords: rel_25_05_candidate
: 40804 (view as bug list)
Depends on: 38714
Blocks:
  Show dependency treegraph
 
Reported: 2025-09-02 23:47 UTC by Todd Goatley
Modified: 2025-10-29 09:09 UTC (History)
10 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.05
Circulation function:


Attachments
Display of order edit (80.97 KB, image/png)
2025-09-02 23:47 UTC, Todd Goatley
Details
Bug 40743: Active funds not visible in Fund dropdown on order receive page (883 bytes, patch)
2025-09-03 15:46 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 40743: Make active funds visible again (2.95 KB, patch)
2025-09-03 15:46 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 40743: Active funds not visible in Fund dropdown on order receive page (931 bytes, patch)
2025-09-05 08:21 UTC, David Nind
Details | Diff | Splinter Review
Bug 40743: Make active funds visible again (3.00 KB, patch)
2025-09-05 08:21 UTC, David Nind
Details | Diff | Splinter Review
Bug 40743: Fix description of inactive budget (1.59 KB, patch)
2025-09-15 13:28 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40743: Make active funds visible again (3.05 KB, patch)
2025-10-22 00:04 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 40743: Fix description of inactive budget (1.65 KB, patch)
2025-10-22 00:04 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 40743: Make active funds visible again (3.13 KB, patch)
2025-10-23 08:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40743: Fix description of inactive budget (1.72 KB, patch)
2025-10-23 08:51 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Todd Goatley 2025-09-02 23:47:34 UTC
Created attachment 186059 [details]
Display of order edit

We are an early adopter to 25.05.02 and we're unable to select the correct fund when paying invoices. This refers to paying paper invoices we receive since as this Baker &Taylor example. Previously, we were given the option to select the fund, and since we have two active funds now due to closing out the fiscal year, we are only able to see one of the active funds (unfortunately not the fund we need to pay this invoice). I checked acquisitions permissions, and Sandra has full ACQ permissions.
Comment 1 Laura Escamilla 2025-09-03 15:46:43 UTC
Created attachment 186083 [details] [review]
Bug 40743: Active funds not visible in Fund dropdown on order receive page
Comment 2 Laura Escamilla 2025-09-03 15:46:45 UTC
Created attachment 186084 [details] [review]
Bug 40743: Make active funds visible again

To test:

1. Create a basket and add an item to the order. Close the basket.
2. Receive shipment. Create an invoice.
3. Go to the invoice and then go to the receipt page.
4. Receive the item you had added to your basket. Under Fund you will only see “Keep current (your budget name)”. Active budgets are not visible.
5. Click on “Show inactive” — both inactive and active budgets become visible.
6. Apply the patch. Restart all.
7. Repeat step 3 and 4. Notice now that the active budgets are visible under your Fund dropdown. On this step you can create an inactive budget / fund if you don’t have one set already. Next click on “Show inactive” and notice that the active fund is active, and the inactive fund has a budget_description of inactive.
8. Test to make sure budgets stick.
9. Sign off and have a wonderful day!
Comment 3 Tomás Cohen Arazi (tcohen) 2025-09-03 15:52:27 UTC
Broken feature, setting 'critical'
Comment 4 David Nind 2025-09-05 08:21:03 UTC
Created attachment 186190 [details] [review]
Bug 40743: Active funds not visible in Fund dropdown on order receive page

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2025-09-05 08:21:10 UTC
Created attachment 186191 [details] [review]
Bug 40743: Make active funds visible again

To test:

1. Create a basket and add an item to the order. Close the basket.
2. Receive shipment. Create an invoice.
3. Go to the invoice and then go to the receipt page.
4. Receive the item you had added to your basket. Under Fund you will only see “Keep current (your budget name)”. Active budgets are not visible.
5. Click on “Show inactive” — both inactive and active budgets become visible.
6. Apply the patch. Restart all.
7. Repeat step 3 and 4. Notice now that the active budgets are visible under your Fund dropdown. On this step you can create an inactive budget / fund if you don’t have one set already. Next click on “Show inactive” and notice that the active fund is active, and the inactive fund has a budget_description of inactive.
8. Test to make sure budgets stick.
9. Sign off and have a wonderful day!

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2025-09-05 08:28:52 UTC
What I noted when receiving (both before and after the patches), is that if you tick inactive, in the list of funds it shows in the dropdown list as:

Current
  Keep current (Whatever the fund was that you selected)
{budget_description}
Inactive
  Inactive fund name
Main budget
  Main fund
  ...
Comment 7 Wainui Witika-Park 2025-09-15 06:33:37 UTC
*** Bug 40804 has been marked as a duplicate of this bug. ***
Comment 8 Jonathan Druart 2025-09-15 13:28:02 UTC
Caused by

  commit ce0ef254112e23ee7ad32225744b5a30d156d8d8
  Bug 38714: acqui/orderreceive.tt

Sorry about that!

I do agree with the second patch, however I don't understand why we need the first one (change to .pl). Can you explain please?
Comment 9 Jonathan Druart 2025-09-15 13:28:13 UTC
Created attachment 186402 [details] [review]
Bug 40743: Fix description of inactive budget

Without this patch it's always "{budget_description} (Inactive)"
Comment 10 Jonathan Druart 2025-09-15 13:28:50 UTC
This last patch fixes a translation issue caused by the same commit.
Comment 11 Marcel de Rooy 2025-09-19 06:37:29 UTC
(In reply to Jonathan Druart from comment #8)
> Caused by
> 
>   commit ce0ef254112e23ee7ad32225744b5a30d156d8d8
>   Bug 38714: acqui/orderreceive.tt
> 
> Sorry about that!
> 
> I do agree with the second patch, however I don't understand why we need the
> first one (change to .pl). Can you explain please?

I dont see any reply about this question. CHanging status for feedback.
Comment 12 Holly Bowden 2025-10-01 15:24:17 UTC
All active budgets not available when receiving in Acq module
Comment 13 Aleisha Amohia 2025-10-21 01:47:20 UTC
We've received some sponsorship to help revive this fix as it's affecting many of our libraries. I don't want to step on toes in case someone else is planning to come back to this - if you are, can you please let me know? Otherwise I'll pick this up in the coming days.
Comment 14 Jonathan Druart 2025-10-21 06:54:30 UTC
(In reply to Aleisha Amohia from comment #13)
> We've received some sponsorship to help revive this fix as it's affecting
> many of our libraries. I don't want to step on toes in case someone else is
> planning to come back to this - if you are, can you please let me know?
> Otherwise I'll pick this up in the coming days.

IMO all it needs is to remove the pl change: ie. obsolete the first patch.
Comment 15 Aleisha Amohia 2025-10-22 00:04:40 UTC
Created attachment 188264 [details] [review]
Bug 40743: Make active funds visible again

To test:

1. Create a basket and add an item to the order. Close the basket.
2. Receive shipment. Create an invoice.
3. Go to the invoice and then go to the receipt page.
4. Receive the item you had added to your basket. Under Fund you will only see “Keep current (your budget name)”. Active budgets are not visible.
5. Click on “Show inactive” — both inactive and active budgets become visible.
6. Apply the patch. Restart all.
7. Repeat step 3 and 4. Notice now that the active budgets are visible under your Fund dropdown. On this step you can create an inactive budget / fund if you don’t have one set already. Next click on “Show inactive” and notice that the active fund is active, and the inactive fund has a budget_description of inactive.
8. Test to make sure budgets stick.
9. Sign off and have a wonderful day!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Aleisha Amohia <aleisha@catalyst.net.nz>
Comment 16 Aleisha Amohia 2025-10-22 00:04:44 UTC
Created attachment 188265 [details] [review]
Bug 40743: Fix description of inactive budget

Without this patch it's always "{budget_description} (Inactive)"

Signed-off-by: Aleisha Amohia <aleisha@catalyst.net.nz>
Comment 17 Aleisha Amohia 2025-10-22 00:05:29 UTC
(In reply to Jonathan Druart from comment #14)
> (In reply to Aleisha Amohia from comment #13)
> > We've received some sponsorship to help revive this fix as it's affecting
> > many of our libraries. I don't want to step on toes in case someone else is
> > planning to come back to this - if you are, can you please let me know?
> > Otherwise I'll pick this up in the coming days.
> 
> IMO all it needs is to remove the pl change: ie. obsolete the first patch.

I tested the two patches and can confirm they solve the problem without the first patch. Setting to Signed Off with the .pl change obsolete.
Comment 18 Jonathan Druart 2025-10-23 08:51:13 UTC
Created attachment 188309 [details] [review]
Bug 40743: Make active funds visible again

To test:

1. Create a basket and add an item to the order. Close the basket.
2. Receive shipment. Create an invoice.
3. Go to the invoice and then go to the receipt page.
4. Receive the item you had added to your basket. Under Fund you will only see “Keep current (your budget name)”. Active budgets are not visible.
5. Click on “Show inactive” — both inactive and active budgets become visible.
6. Apply the patch. Restart all.
7. Repeat step 3 and 4. Notice now that the active budgets are visible under your Fund dropdown. On this step you can create an inactive budget / fund if you don’t have one set already. Next click on “Show inactive” and notice that the active fund is active, and the inactive fund has a budget_description of inactive.
8. Test to make sure budgets stick.
9. Sign off and have a wonderful day!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Aleisha Amohia <aleisha@catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 19 Jonathan Druart 2025-10-23 08:51:15 UTC
Created attachment 188310 [details] [review]
Bug 40743: Fix description of inactive budget

Without this patch it's always "{budget_description} (Inactive)"

Signed-off-by: Aleisha Amohia <aleisha@catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 20 Lucas Gass (lukeg) 2025-10-24 13:58:59 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 21 Paul Derscheid 2025-10-29 09:09:52 UTC
Nice work everyone!

Pushed to 25.05.x