Created attachment 186059 [details] Display of order edit We are an early adopter to 25.05.02 and we're unable to select the correct fund when paying invoices. This refers to paying paper invoices we receive since as this Baker &Taylor example. Previously, we were given the option to select the fund, and since we have two active funds now due to closing out the fiscal year, we are only able to see one of the active funds (unfortunately not the fund we need to pay this invoice). I checked acquisitions permissions, and Sandra has full ACQ permissions.
Created attachment 186083 [details] [review] Bug 40743: Active funds not visible in Fund dropdown on order receive page
Created attachment 186084 [details] [review] Bug 40743: Make active funds visible again To test: 1. Create a basket and add an item to the order. Close the basket. 2. Receive shipment. Create an invoice. 3. Go to the invoice and then go to the receipt page. 4. Receive the item you had added to your basket. Under Fund you will only see “Keep current (your budget name)”. Active budgets are not visible. 5. Click on “Show inactive” — both inactive and active budgets become visible. 6. Apply the patch. Restart all. 7. Repeat step 3 and 4. Notice now that the active budgets are visible under your Fund dropdown. On this step you can create an inactive budget / fund if you don’t have one set already. Next click on “Show inactive” and notice that the active fund is active, and the inactive fund has a budget_description of inactive. 8. Test to make sure budgets stick. 9. Sign off and have a wonderful day!
Broken feature, setting 'critical'
Created attachment 186190 [details] [review] Bug 40743: Active funds not visible in Fund dropdown on order receive page Signed-off-by: David Nind <david@davidnind.com>
Created attachment 186191 [details] [review] Bug 40743: Make active funds visible again To test: 1. Create a basket and add an item to the order. Close the basket. 2. Receive shipment. Create an invoice. 3. Go to the invoice and then go to the receipt page. 4. Receive the item you had added to your basket. Under Fund you will only see “Keep current (your budget name)”. Active budgets are not visible. 5. Click on “Show inactive” — both inactive and active budgets become visible. 6. Apply the patch. Restart all. 7. Repeat step 3 and 4. Notice now that the active budgets are visible under your Fund dropdown. On this step you can create an inactive budget / fund if you don’t have one set already. Next click on “Show inactive” and notice that the active fund is active, and the inactive fund has a budget_description of inactive. 8. Test to make sure budgets stick. 9. Sign off and have a wonderful day! Signed-off-by: David Nind <david@davidnind.com>
What I noted when receiving (both before and after the patches), is that if you tick inactive, in the list of funds it shows in the dropdown list as: Current Keep current (Whatever the fund was that you selected) {budget_description} Inactive Inactive fund name Main budget Main fund ...
*** Bug 40804 has been marked as a duplicate of this bug. ***
Caused by commit ce0ef254112e23ee7ad32225744b5a30d156d8d8 Bug 38714: acqui/orderreceive.tt Sorry about that! I do agree with the second patch, however I don't understand why we need the first one (change to .pl). Can you explain please?
Created attachment 186402 [details] [review] Bug 40743: Fix description of inactive budget Without this patch it's always "{budget_description} (Inactive)"
This last patch fixes a translation issue caused by the same commit.
(In reply to Jonathan Druart from comment #8) > Caused by > > commit ce0ef254112e23ee7ad32225744b5a30d156d8d8 > Bug 38714: acqui/orderreceive.tt > > Sorry about that! > > I do agree with the second patch, however I don't understand why we need the > first one (change to .pl). Can you explain please? I dont see any reply about this question. CHanging status for feedback.
All active budgets not available when receiving in Acq module
We've received some sponsorship to help revive this fix as it's affecting many of our libraries. I don't want to step on toes in case someone else is planning to come back to this - if you are, can you please let me know? Otherwise I'll pick this up in the coming days.
(In reply to Aleisha Amohia from comment #13) > We've received some sponsorship to help revive this fix as it's affecting > many of our libraries. I don't want to step on toes in case someone else is > planning to come back to this - if you are, can you please let me know? > Otherwise I'll pick this up in the coming days. IMO all it needs is to remove the pl change: ie. obsolete the first patch.
Created attachment 188264 [details] [review] Bug 40743: Make active funds visible again To test: 1. Create a basket and add an item to the order. Close the basket. 2. Receive shipment. Create an invoice. 3. Go to the invoice and then go to the receipt page. 4. Receive the item you had added to your basket. Under Fund you will only see “Keep current (your budget name)”. Active budgets are not visible. 5. Click on “Show inactive” — both inactive and active budgets become visible. 6. Apply the patch. Restart all. 7. Repeat step 3 and 4. Notice now that the active budgets are visible under your Fund dropdown. On this step you can create an inactive budget / fund if you don’t have one set already. Next click on “Show inactive” and notice that the active fund is active, and the inactive fund has a budget_description of inactive. 8. Test to make sure budgets stick. 9. Sign off and have a wonderful day! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleisha@catalyst.net.nz>
Created attachment 188265 [details] [review] Bug 40743: Fix description of inactive budget Without this patch it's always "{budget_description} (Inactive)" Signed-off-by: Aleisha Amohia <aleisha@catalyst.net.nz>
(In reply to Jonathan Druart from comment #14) > (In reply to Aleisha Amohia from comment #13) > > We've received some sponsorship to help revive this fix as it's affecting > > many of our libraries. I don't want to step on toes in case someone else is > > planning to come back to this - if you are, can you please let me know? > > Otherwise I'll pick this up in the coming days. > > IMO all it needs is to remove the pl change: ie. obsolete the first patch. I tested the two patches and can confirm they solve the problem without the first patch. Setting to Signed Off with the .pl change obsolete.
Created attachment 188309 [details] [review] Bug 40743: Make active funds visible again To test: 1. Create a basket and add an item to the order. Close the basket. 2. Receive shipment. Create an invoice. 3. Go to the invoice and then go to the receipt page. 4. Receive the item you had added to your basket. Under Fund you will only see “Keep current (your budget name)”. Active budgets are not visible. 5. Click on “Show inactive” — both inactive and active budgets become visible. 6. Apply the patch. Restart all. 7. Repeat step 3 and 4. Notice now that the active budgets are visible under your Fund dropdown. On this step you can create an inactive budget / fund if you don’t have one set already. Next click on “Show inactive” and notice that the active fund is active, and the inactive fund has a budget_description of inactive. 8. Test to make sure budgets stick. 9. Sign off and have a wonderful day! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleisha@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 188310 [details] [review] Bug 40743: Fix description of inactive budget Without this patch it's always "{budget_description} (Inactive)" Signed-off-by: Aleisha Amohia <aleisha@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x