The buttons in the plugins home page ("Upload plugin" and "View plugins by class") become misaligned when you have the git repository search bar. To recreate: 1. Go to Administration > Manage plugins --> Page looks fine, buttons are aligned nicely 2. Add a github/gitlab repository in koha-conf.xml - In ktd shell, open /etc/koha/sites/kohadev/koha-conf.xml - Somewhere under <config> insert the following (or your own) <plugin_repos> <repo> <name>Solutions inLibro</name> <org_name>inLibro</org_name> <service>github</service> </repo> </plugin_repos> - Save the file - restart_all 3. Repeat step 1 (hard refresh page) --> Buttons are misaligned
Created attachment 186377 [details] [review] Bug 40787: Plugins buttons misaligned when search box is enabled The buttons in the plugins home page ("Upload plugin" and "View plugins by class") become misaligned when you have the git repository search bar. To test: 1. Add a github/gitlab repository in koha-conf.xml - In ktd shell, open /etc/koha/sites/kohadev/koha-conf.xml - Somewhere under <config> insert the following (or your own) <plugin_repos> <repo> <name>Solutions inLibro</name> <org_name>inLibro</org_name> <service>github</service> </repo> </plugin_repos> - Save the file - restart_all 2. Go to Administration > Manage plugins --> Buttons are misaligned 3. Apply the patch 4. Repeat step 2 --> buttons are aligned nicely
Created attachment 186378 [details] [review] Bug 40787: Plugins buttons misaligned when search box is enabled The buttons in the plugins home page ("Upload plugin" and "View plugins by class") become misaligned when you have the git repository search bar. To test: 1. Add a github/gitlab repository in koha-conf.xml - In ktd shell, open /etc/koha/sites/kohadev/koha-conf.xml - Somewhere under <config> insert the following (or your own) <plugin_repos> <repo> <name>Solutions inLibro</name> <org_name>inLibro</org_name> <service>github</service> </repo> </plugin_repos> - Save the file - restart_all 2. Go to Administration > Manage plugins --> Buttons are misaligned 3. Apply the patch 4. Run command « yarn build » 5. Repeat step 2 --> buttons are aligned nicely
I can't sign off since I work with Hammat, but it works for me.
Created attachment 189486 [details] [review] Bug 40787: Plugins buttons misaligned when search box is enabled The buttons in the plugins home page ("Upload plugin" and "View plugins by class") become misaligned when you have the git repository search bar. To test: 1. Add a github/gitlab repository in koha-conf.xml - In ktd shell, open /etc/koha/sites/kohadev/koha-conf.xml - Somewhere under <config> insert the following (or your own) <plugin_repos> <repo> <name>Solutions inLibro</name> <org_name>inLibro</org_name> <service>github</service> </repo> </plugin_repos> - Save the file - restart_all 2. Go to Administration > Manage plugins --> Buttons are misaligned 3. Apply the patch 4. Run command « yarn build » 5. Repeat step 2 --> buttons are aligned nicely Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. Step 1 is not required for the latest KTD. 2. Not related to this bug, but if I actually search, for example for 'patrons', I get this error: malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm line 190 in JSON::from_json at /usr/share/perl5/JSON.pm line 190 187: } 188: } 189: 190: return $json->decode( $_[0] ); 191: }
(In reply to David Nind from comment #5) > 2. Not related to this bug, but if I actually search, for example for > 'patrons', I get this error: > > malformed JSON string, neither tag, array, object, number, string or atom, > at character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm > line 190 > in JSON::from_json at /usr/share/perl5/JSON.pm line 190 > 187: } > 188: } > 189: > 190: return $json->decode( $_[0] ); > 191: } This may be related to Bug 26952 - plugin search term is not correct escaped
(In reply to David Nind from comment #5) > 2. Not related to this bug, but if I actually search, for example for > 'patrons', I get this error: > > malformed JSON string, neither tag, array, object, number, string or atom, > at character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm > line 190 > in JSON::from_json at /usr/share/perl5/JSON.pm line 190 > 187: } > 188: } > 189: > 190: return $json->decode( $_[0] ); > 191: } To avoid this error in current main: 1. Remove this repo from /etc/koha/sites/kohadev/koha-conf.xml: <repo> <name>PTFS Europe</name> <org_name>PTFS-Europe</org_name> <service>github</service> </repo> 2. Change the setting for plugins_restricted to (that is, from 1 to 0): <plugins_restricted>0</plugins_restricted>
Created attachment 189596 [details] Alternative option: Search form in sidebar Before I knew there was a bug report for this issue I started working on this alternative, putting the form in the sidebar. That feels more consistent to me than putting the search in the toolbar. See also the saved reports page and Acquisitions -> Invoices.
(In reply to Owen Leonard from comment #8) > Created attachment 189596 [details] > Alternative option: Search form in sidebar I like it!