Bug 40787 - Plugins buttons misaligned when search box is enabled
Summary: Plugins buttons misaligned when search box is enabled
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Hammat wele
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-09-10 15:53 UTC by Caroline Cyr La Rose
Modified: 2025-11-14 12:55 UTC (History)
5 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40787: Plugins buttons misaligned when search box is enabled (1.45 KB, patch)
2025-09-11 17:06 UTC, Hammat wele
Details | Diff | Splinter Review
Bug 40787: Plugins buttons misaligned when search box is enabled (1.57 KB, patch)
2025-09-11 17:09 UTC, Hammat wele
Details | Diff | Splinter Review
Bug 40787: Plugins buttons misaligned when search box is enabled (1.62 KB, patch)
2025-11-11 10:33 UTC, David Nind
Details | Diff | Splinter Review
Alternative option: Search form in sidebar (67.65 KB, image/png)
2025-11-14 12:30 UTC, Owen Leonard
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2025-09-10 15:53:32 UTC
The buttons in the plugins home page ("Upload plugin" and "View plugins by class") become misaligned when you have the git repository search bar.

To recreate:
1. Go to Administration > Manage plugins
--> Page looks fine, buttons are aligned nicely

2. Add a github/gitlab repository in koha-conf.xml
  - In ktd shell, open /etc/koha/sites/kohadev/koha-conf.xml
  - Somewhere under <config> insert the following (or your own)

<plugin_repos>
  <repo>
   <name>Solutions inLibro</name>
   <org_name>inLibro</org_name>
   <service>github</service>
  </repo>
</plugin_repos>

  - Save the file
  - restart_all

3. Repeat step 1 (hard refresh page)
--> Buttons are misaligned
Comment 1 Hammat wele 2025-09-11 17:06:38 UTC Comment hidden (obsolete)
Comment 2 Hammat wele 2025-09-11 17:09:50 UTC
Created attachment 186378 [details] [review]
Bug 40787: Plugins buttons misaligned when search box is enabled

The buttons in the plugins home page ("Upload plugin" and "View plugins by class") become misaligned when you have the git repository search bar.

To test:

1. Add a github/gitlab repository in koha-conf.xml
  - In ktd shell, open /etc/koha/sites/kohadev/koha-conf.xml
  - Somewhere under <config> insert the following (or your own)

<plugin_repos>
  <repo>
   <name>Solutions inLibro</name>
   <org_name>inLibro</org_name>
   <service>github</service>
  </repo>
</plugin_repos>

  - Save the file
  - restart_all

2. Go to Administration > Manage plugins
--> Buttons are misaligned

3. Apply the patch

4. Run command « yarn build »

5. Repeat step 2
--> buttons are aligned nicely
Comment 3 Caroline Cyr La Rose 2025-09-11 18:03:52 UTC
I can't sign off since I work with Hammat, but it works for me.
Comment 4 David Nind 2025-11-11 10:33:12 UTC
Created attachment 189486 [details] [review]
Bug 40787: Plugins buttons misaligned when search box is enabled

The buttons in the plugins home page ("Upload plugin" and "View plugins by class") become misaligned when you have the git repository search bar.

To test:

1. Add a github/gitlab repository in koha-conf.xml
  - In ktd shell, open /etc/koha/sites/kohadev/koha-conf.xml
  - Somewhere under <config> insert the following (or your own)

<plugin_repos>
  <repo>
   <name>Solutions inLibro</name>
   <org_name>inLibro</org_name>
   <service>github</service>
  </repo>
</plugin_repos>

  - Save the file
  - restart_all

2. Go to Administration > Manage plugins
--> Buttons are misaligned

3. Apply the patch

4. Run command « yarn build »

5. Repeat step 2
--> buttons are aligned nicely

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2025-11-11 10:38:16 UTC
Testing notes (using KTD):

1. Step 1 is not required for the latest KTD.

2. Not related to this bug, but if I actually search, for example for 'patrons', I get this error:

malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm line 190
in JSON::from_json at /usr/share/perl5/JSON.pm line 190
  187:         }
  188:     }
  189: 
  190:     return $json->decode( $_[0] );
  191: }
Comment 6 David Nind 2025-11-13 18:27:32 UTC Comment hidden (obsolete)
Comment 7 David Nind 2025-11-13 19:03:13 UTC
(In reply to David Nind from comment #5)

> 2. Not related to this bug, but if I actually search, for example for
> 'patrons', I get this error:
> 
> malformed JSON string, neither tag, array, object, number, string or atom,
> at character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm
> line 190
> in JSON::from_json at /usr/share/perl5/JSON.pm line 190
>   187:         }
>   188:     }
>   189: 
>   190:     return $json->decode( $_[0] );
>   191: }

To avoid this error in current main:

1. Remove this repo from /etc/koha/sites/kohadev/koha-conf.xml:

   <repo>
       <name>PTFS Europe</name>
       <org_name>PTFS-Europe</org_name>
       <service>github</service>
   </repo>

2. Change the setting for plugins_restricted to (that is, from 1 to 0):
     <plugins_restricted>0</plugins_restricted>
Comment 8 Owen Leonard 2025-11-14 12:30:00 UTC
Created attachment 189596 [details]
Alternative option: Search form in sidebar

Before I knew there was a bug report for this issue I started working on this alternative, putting the form in the sidebar. That feels more consistent to me than putting the search in the toolbar. See also the saved reports page and Acquisitions -> Invoices.
Comment 9 Jonathan Druart 2025-11-14 12:55:33 UTC
(In reply to Owen Leonard from comment #8)
> Created attachment 189596 [details]
> Alternative option: Search form in sidebar

I like it!