Bug 40819 - Guided reports select column should not be initialized as select2
Summary: Guided reports select column should not be initialized as select2
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Brendan Lawlor
QA Contact: Testopia
URL:
Keywords: roadmap_25_05
Depends on: 37050
Blocks:
  Show dependency treegraph
 
Reported: 2025-09-16 17:41 UTC by Brendan Lawlor
Modified: 2025-10-16 09:14 UTC (History)
3 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.04
Circulation function:


Attachments
Bug 40819: Only initialize select2 for #report_param_form (1.58 KB, patch)
2025-09-16 17:54 UTC, Brendan Lawlor
Details | Diff | Splinter Review
Bug 40819: Only initialize select2 for #report_param_form (1.65 KB, patch)
2025-09-19 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Lawlor 2025-09-16 17:41:52 UTC
This is a follow up from bug 37050.

To reproduce:
1. Go to Reports > Create guided report
2. Click Next >>
3. Click Next >>
3. Notice the form has been initialized as select2
Comment 1 Brendan Lawlor 2025-09-16 17:54:08 UTC
Created attachment 186503 [details] [review]
Bug 40819: Only initialize select2 for #report_param_form

This patch makes the the css selector specifically target the
report_param_form in guided reports

To test:
1. Go to Reports > Create guided report
2. Click Next >>
3. Click Next >>
3. Notice the form has been initialized as select2
4. Apply patch and refresh the page
5. Confirm the select column form is back to normal
6. Confirm select2 is still initialized for SQL reports
   example: select * from items where homebranch IN <<Library|branches:in>>
Comment 2 Jonathan Druart 2025-09-19 07:22:35 UTC
Created attachment 186605 [details] [review]
Bug 40819: Only initialize select2 for #report_param_form

This patch makes the the css selector specifically target the
report_param_form in guided reports

To test:
1. Go to Reports > Create guided report
2. Click Next >>
3. Click Next >>
3. Notice the form has been initialized as select2
4. Apply patch and refresh the page
5. Confirm the select column form is back to normal
6. Confirm select2 is still initialized for SQL reports
   example: select * from items where homebranch IN <<Library|branches:in>>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Jonathan Druart 2025-09-19 07:23:23 UTC
Trivial but major, passing QA.
Comment 4 Lucas Gass (lukeg) 2025-09-19 14:45:26 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 5 Paul Derscheid 2025-09-25 16:31:26 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 6 Fridolin Somers 2025-10-16 09:14:55 UTC
Depends on Bug 37050 not in 24.11.x