Update koha-tmpl/intranet-tmpl/prog/en/includes/wrapper-staff-tool-plugin.into include the reports menu and have the breadcrumbs list reports instead of admin/tools when method="report"
Makes sense. Having some regrets calling it "wrapper-staff-tool-plugin.inc" now heh.
Created attachment 188173 [details] [review] Bug 40827: Add context to plugin wrapper for report plugins This patch updates the plugin wrapper to include the reports menu and have the breadcrumbs list reports instead of admin or tools when method="report" To Test: 1. Install the Kitchen Sink Plugin 2. Navigate to Reports->Report plugins->Run Report. 3. Observe the admin menu shows 4. Apply the patch 5. Repeat step 2 6. Observe the report menu shows and the breadcrumbs are for the report module. 7. Check that the tools and configuration show the appropriate tool/admin context.
The patch looks good at a glance, but the test plan doesn't work when using either the dev or non-dev Kitchen Sink Plugin v2.6.3. It looks like the templates are changed in the main branch, but not in a released version of the plugin.
That being said... I've hacked on my own plugin which uses the plugin wrapper and the change definitely works and it works well. If you can provide an updated test plan and get someone to sign off, I can QA this. It's a good change.
Actually... this is such a small yet useful change... I think we might be able to leapfrog...
Created attachment 188454 [details] [review] Bug 40827: Add context to plugin wrapper for report plugins This patch updates the plugin wrapper to include the reports menu and have the breadcrumbs list reports instead of admin or tools when method="report" To Test: 1. Install the Kitchen Sink Plugin 2. Navigate to Reports->Report plugins->Run Report. 3. Observe the admin menu shows 4. Apply the patch 5. Repeat step 2 6. Observe the report menu shows and the breadcrumbs are for the report module. 7. Check that the tools and configuration show the appropriate tool/admin context. Signed-off-by: David Cook <dcook@prosentient.com.au>
For people implementing this, you can pass the "method" via $template->{VARS}->{method} or you can hard-code it into your template like this: [% WRAPPER "wrapper-staff-tool-plugin.inc" method="report" plugin_title="Kitchen Sink Plugin: Patron List" %] They both work.
Nice work everyone! Pushed to main for 25.11