In the patron account on the OPAC, the Type column is meant to show the description value for the associated credit or debit type (account_credit_types.description or account_debit_types.description). But the Type column is empty for any credit or debit type that's defined locally. All of the system-defined credit and debit types have this value hardcoded in the accounts.inc file, rather than actually fetching the value from the database. To recreate: - create a credit type that can be applied manually - create a debit type that can be applied manually - apply both a credit and debit to your patron (make sure auto-reconcile is off) - look at your patron's account in the staff interface, see values in the "account type" column - look at your patron's account in the OPAC, see the "Type" column is blank
Created attachment 189349 [details] [review] Bug 40836: OPAC Type column should show local debit/credit type descriptions To test: 1. create a credit type that can be applied manually 2. create a debit type that can be applied manually 3. apply both a credit and debit to your patron (make sure auto-reconcile is off) 4. look at your patron's account in the staff interface, see values in the "account type" column 5. look at your patron's account in the OPAC, see the "Type" column is blank 6. Apply the patch - restart_all 7. Refresh the patron’s account in the OPAC — clear browser cache if necessary. The Type columns should now be populated.
Created attachment 189366 [details] [review] Bug 40836: OPAC Type column should show local debit/credit type descriptions To test: 1. create a credit type that can be applied manually 2. create a debit type that can be applied manually 3. apply both a credit and debit to your patron (make sure auto-reconcile is off) 4. look at your patron's account in the staff interface, see values in the "account type" column 5. look at your patron's account in the OPAC, see the "Type" column is blank 6. Apply the patch - restart_all 7. Refresh the patron’s account in the OPAC — clear browser cache if necessary. The Type columns should now be populated. Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org>
Patch works to restore show of custom defined credit and debit types in the OPAC interface. No issues testing.
Created attachment 189672 [details] [review] Bug 40836: OPAC Type column should show local debit/credit type descriptions To test: 1. create a credit type that can be applied manually 2. create a debit type that can be applied manually 3. apply both a credit and debit to your patron (make sure auto-reconcile is off) 4. look at your patron's account in the staff interface, see values in the "account type" column 5. look at your patron's account in the OPAC, see the "Type" column is blank 6. Apply the patch - restart_all 7. Refresh the patron’s account in the OPAC — clear browser cache if necessary. The Type columns should now be populated. Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org>
Created attachment 189673 [details] [review] Bug 40836: (QA follow-up) Reduce params Reduce params given to process method.
Everything worked as described. I removed debit_type_code and credit_type_code from the params as they are part of account. And I forgot to put my sign off under the patch
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x
Pushed to 24.11.x for 24.11.11