Bug 40854 - Staff interface search results browsing is broken
Summary: Staff interface search results browsing is broken
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Andrew Fuerste-Henry
QA Contact: Marcel de Rooy
URL:
Keywords: rel_25_05_candidate
: 40887 41014 (view as bug list)
Depends on: 37222
Blocks:
  Show dependency treegraph
 
Reported: 2025-09-22 18:52 UTC by Andrew Fuerste-Henry
Modified: 2025-10-31 23:06 UTC (History)
9 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the sidebar menu on the record details page in the staff interface, so that the search results browsing tool appears. A change from Bug 37222 - Standardize markup for sidebar menus (added to Koha 25.05) was causing the search results browser tool not to show on a record's details page after selecting a title from the search results.
Version(s) released in:
25.11.00,25.05.05
Circulation function:


Attachments
Bug 40854: Correct menu name in browser.js (1.42 KB, patch)
2025-09-22 18:57 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 40854: Correct menu name in browser.js (1.48 KB, patch)
2025-09-23 18:11 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 40854: Correct menu name in browser.js (1.57 KB, patch)
2025-09-26 06:47 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2025-09-22 18:52:31 UTC
Bug 37222 renamed the sidebar menu on the biblio details page, which is causing the results browsing tool to not appear.
Comment 1 Andrew Fuerste-Henry 2025-09-22 18:57:17 UTC
Created attachment 186739 [details] [review]
Bug 40854: Correct menu name in browser.js

To test:
1 - perform a search in the staff interface, click a title to go to biblio details
2 - note lack of search results browsing tools at top left of page
3 - apply patch
4 - repeat your search, click a title to go to biblio details
5 - note browsing results tools at top left of page
Comment 2 Andrew Fuerste-Henry 2025-09-23 18:11:05 UTC
Created attachment 186841 [details] [review]
Bug 40854: Correct menu name in browser.js

To test:
1 - perform a search in the staff interface, click a title to go to biblio details
2 - note lack of search results browsing tools at top left of page
3 - apply patch
4 - repeat your search, click a title to go to biblio details
5 - note browsing results tools at top left of page

Signed-off-by: Kevin Kellenberger <kkellenberger@mrcpl.org>
Comment 3 Marcel de Rooy 2025-09-26 06:47:44 UTC
Created attachment 186957 [details] [review]
Bug 40854: Correct menu name in browser.js

To test:
1 - perform a search in the staff interface, click a title to go to biblio details
2 - note lack of search results browsing tools at top left of page
3 - apply patch
4 - repeat your search, click a title to go to biblio details
5 - note browsing results tools at top left of page

Signed-off-by: Kevin Kellenberger <kkellenberger@mrcpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Lucas Gass (lukeg) 2025-09-26 15:12:49 UTC
Nice job all! 

Pushed to main for 25.11.00.
Comment 5 Emily Lamancusa (emlam) 2025-09-26 17:59:09 UTC
*** Bug 40887 has been marked as a duplicate of this bug. ***
Comment 6 Angela Berrett 2025-09-26 20:27:20 UTC
Is this able to be backported into 25.05?
Comment 7 Phil Ringnalda 2025-10-16 23:01:51 UTC
*** Bug 41014 has been marked as a duplicate of this bug. ***
Comment 8 Paul Derscheid 2025-10-23 21:11:07 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 9 Fridolin Somers 2025-10-31 13:47:35 UTC
Depends on Bug 37222 not in 24.11.x
Comment 10 David Nind 2025-10-31 23:06:32 UTC
Bug fix, no changes to the manual required.