Bug 40892 - ILL tab with no requests shows all instead
Summary: ILL tab with no requests shows all instead
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 30200
Blocks:
  Show dependency treegraph
 
Reported: 2025-09-26 22:33 UTC by Eric Phetteplace
Modified: 2025-11-03 07:51 UTC (History)
5 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Phetteplace 2025-09-26 22:33:28 UTC
With the ILLRequestsTabs feature, if you create a tab for a status which has no matching ILL requests, that tab displays _all_ requests instead of none. We have a tab "new" tab (see below) that exhibits this behavior whenever there are no status=NEW requests.

Here's a rough way to recreate this on a new system:

- Enable ILLModule setting
- Create a few ILL requests
- Edit ILLRequestsTabs setting to have two tabs
```
- name: New
  status:
  - NEW
- name: Completed
  status:
  - COMP
```
- Go to the requests module on the staff side
- Select the "Completed" tab
- There should be 0 requests; instead you see all of them
Comment 1 Lisette Scheer 2025-10-22 15:56:46 UTC
From a little testing it seems to work as long as all of the listed statuses have at least one item. 

Example from INNReach today:
- name: Lending
  status:
    - O_ITEM_CHECKED_IN
- name: Borrowing
  status:
    - B_ITEM_REQUESTED

If there's nothing currently in B_ITEM_REQUESTED the tabs don't work at all.