Bug 40929 - Can't call method "borrowernumber" on an undefined value at opac-modrequest.pl
Summary: Can't call method "borrowernumber" on an undefined value at opac-modrequest.pl
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Marcel de Rooy
QA Contact: Tomás Cohen Arazi (tcohen)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-10-01 14:33 UTC by Marcel de Rooy
Modified: 2025-10-06 15:17 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 40929: Add $hold test in opac-modrequest (1.00 KB, patch)
2025-10-01 14:38 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 40929: Add $hold test in opac-modrequest (1.11 KB, patch)
2025-10-01 15:25 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2025-10-01 14:33:05 UTC
From 24.11 log:
Can't call method "borrowernumber" on an undefined value at /usr/share/koha/opac/opac-modrequest.pl line 50.
Comment 1 Marcel de Rooy 2025-10-01 14:38:36 UTC
Created attachment 187199 [details] [review]
Bug 40929: Add $hold test in opac-modrequest

Test plan:
Login at OPAC.
Pass an unexisting reserve_id in a opac-modrequest.pl URL.
Verify that you get a 403 redirect.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2025-10-01 14:38:59 UTC
Super trivial. Self signoff.
Comment 3 Tomás Cohen Arazi (tcohen) 2025-10-01 15:25:54 UTC
Created attachment 187208 [details] [review]
Bug 40929: Add $hold test in opac-modrequest

Test plan:
Login at OPAC.
Pass an unexisting reserve_id in a opac-modrequest.pl URL.
Verify that you get a 403 redirect.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 4 Lucas Gass (lukeg) 2025-10-06 15:17:25 UTC
Nice work everyone!

Pushed to main for 25.11