Executing marc_ordering_process.pl will fail to run with the following errors: /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 21: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 23: marc_ordering_process.pl: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 25: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 27: --confirm]: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 27: --verbose]: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 27: ./marc_ordering_process.pl: No such file or directory /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 29: or,: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 31: 0: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 33: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 35: This: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 36: If: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 38: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 40: =over: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 42: syntax error near unexpected token `newline' /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 42: `=item B<-v|--verbose>' This is due to an inadvertent newline before the shebang of the script.
Created attachment 187429 [details] [review] Bug 40953: marc_ordering_process.pl broken due to accidental newline Executing marc_ordering_process.pl will fail to run with the following errors: /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 21: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 23: marc_ordering_process.pl: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 25: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 27: --confirm]: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 27: --verbose]: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 27: ./marc_ordering_process.pl: No such file or directory /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 29: or,: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 31: 0: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 33: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 35: This: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 36: If: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 38: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 40: =over: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 42: syntax error near unexpected token `newline' /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 42: `=item B<-v|--verbose>' This is due to an inadvertent newline before the shebang of the script. Test Plan: 1) Run ./misc/cronjobs/marc_ordering_process.pl 2) Note the error 3) Apply this patch 4) Run ./misc/cronjobs/marc_ordering_process.pl 5) No error!
Created attachment 187430 [details] [review] Bug 40953: marc_ordering_process.pl broken due to accidental newline Executing marc_ordering_process.pl will fail to run with the following errors: /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 21: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 23: marc_ordering_process.pl: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 25: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 27: --confirm]: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 27: --verbose]: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 27: ./marc_ordering_process.pl: No such file or directory /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 29: or,: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 31: 0: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 33: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 35: This: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 36: If: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 38: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 40: =over: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 42: syntax error near unexpected token `newline' /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 42: `=item B<-v|--verbose>' This is due to an inadvertent newline before the shebang of the script. Test Plan: 1) Run ./misc/cronjobs/marc_ordering_process.pl 2) Note the error 3) Apply this patch 4) Run ./misc/cronjobs/marc_ordering_process.pl 5) No error! Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Trivial fix to a big problem, straight PQA.
Nice work everyone! Pushed to main for 25.11