misc/search_tools/rebuild_elasticsearch.pl has an option --where to pass arbitrary SQL to select which records to index. The koha-elasticsearch wrapper script is missing this option. Add it!
Created attachment 187530 [details] [review] Bug 40964: add --where to koha-elasticsearch wrapper scripts and document it Test Plan: * Start and enter ktd * run koha-elasticsearch with --where, which has no effect: debian/scripts/koha-elasticsearch --rebuild -b -v --where 'biblionumber > 427' kohadev * But you will see some warnings like: Unknown instance --where Unknown instance biblionumber > 427 * Final output is: Total 435 records indexed Apply the patch * run the same command again: debian/scripts/koha-elasticsearch --rebuild -b -v --where 'biblionumber > 427' kohadev * output should be Checking state of biblios index Indexing biblios Committing final records... Total 11 records indexed * Run `debian/scripts/koha-elasticsearch --help` * "-w|--where" should show up in the docs Sponsored-by: HKS3 Sponsored-by: Koha DACH Hackfest
Created attachment 187555 [details] [review] Bug 40964: add --where to koha-elasticsearch wrapper scripts and document it Test Plan: * Start and enter ktd * run koha-elasticsearch with --where, which has no effect: debian/scripts/koha-elasticsearch --rebuild -b -v --where 'biblionumber > 427' kohadev * But you will see some warnings like: Unknown instance --where Unknown instance biblionumber > 427 * Final output is: Total 435 records indexed Apply the patch * run the same command again: debian/scripts/koha-elasticsearch --rebuild -b -v --where 'biblionumber > 427' kohadev * output should be Checking state of biblios index Indexing biblios Committing final records... Total 11 records indexed * Run `debian/scripts/koha-elasticsearch --help` * "-w|--where" should show up in the docs Sponsored-by: HKS3 Sponsored-by: Koha DACH Hackfest Signed-off-by: John Doe <you@example.com> Signed-off-by: Anke Bruns <anke.bruns@gwdg.de>
see also #35345 (the actual implementation in rebuild_elasticsearch.pl)
Created attachment 188361 [details] [review] Bug 40964: add --where to koha-elasticsearch wrapper scripts and document it Test Plan: * Start and enter ktd * run koha-elasticsearch with --where, which has no effect: debian/scripts/koha-elasticsearch --rebuild -b -v --where 'biblionumber > 427' kohadev * But you will see some warnings like: Unknown instance --where Unknown instance biblionumber > 427 * Final output is: Total 435 records indexed Apply the patch * run the same command again: debian/scripts/koha-elasticsearch --rebuild -b -v --where 'biblionumber > 427' kohadev * output should be Checking state of biblios index Indexing biblios Committing final records... Total 11 records indexed * Run `debian/scripts/koha-elasticsearch --help` * "-w|--where" should show up in the docs Sponsored-by: HKS3 Sponsored-by: Koha DACH Hackfest Signed-off-by: Anke Bruns <anke.bruns@gwdg.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 188362 [details] [review] bug 40964: Add long version of options to man Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Removed John Doe's signed-off-by line.
Please fix this commit message: bug 40964: Add long version of options to man * Commit title does not start with 'Bug XXXXX: ' - 7031c83280b
Created attachment 189001 [details] [review] Bug 40964: Add long version of options to man Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to main for 25.11