Bug 40964 - koha-elasticsearch is missing --where option
Summary: koha-elasticsearch is missing --where option
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-10-07 13:55 UTC by Thomas Klausner
Modified: 2025-10-08 11:07 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40964: add --where to koha-elasticsearch wrapper scripts and document it (3.49 KB, patch)
2025-10-07 14:47 UTC, Thomas Klausner
Details | Diff | Splinter Review
Bug 40964: add --where to koha-elasticsearch wrapper scripts and document it (3.56 KB, patch)
2025-10-08 11:05 UTC, Anke Bruns
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Klausner 2025-10-07 13:55:09 UTC
misc/search_tools/rebuild_elasticsearch.pl has an option --where to pass arbitrary SQL to select which records to index.

The koha-elasticsearch wrapper script is missing this option.

Add it!
Comment 1 Thomas Klausner 2025-10-07 14:47:02 UTC
Created attachment 187530 [details] [review]
Bug 40964: add --where to koha-elasticsearch wrapper scripts and document it

Test Plan:

* Start and enter ktd
* run koha-elasticsearch with --where, which has no effect:
  debian/scripts/koha-elasticsearch --rebuild -b -v --where 'biblionumber > 427'  kohadev
* But you will see some warnings like:
  Unknown instance --where
  Unknown instance biblionumber > 427
* Final output is: Total 435 records indexed

Apply the patch

* run the same command again:
  debian/scripts/koha-elasticsearch --rebuild -b -v --where 'biblionumber > 427'  kohadev
* output should be
 Checking state of biblios index
 Indexing biblios
 Committing final records...
 Total 11 records indexed

* Run `debian/scripts/koha-elasticsearch --help`
* "-w|--where" should show up in the docs

Sponsored-by: HKS3
Sponsored-by: Koha DACH Hackfest
Comment 2 Anke Bruns 2025-10-08 11:05:02 UTC
Created attachment 187555 [details] [review]
Bug 40964: add --where to koha-elasticsearch wrapper scripts and document it

Test Plan:

* Start and enter ktd
* run koha-elasticsearch with --where, which has no effect:
  debian/scripts/koha-elasticsearch --rebuild -b -v --where 'biblionumber > 427'  kohadev
* But you will see some warnings like:
  Unknown instance --where
  Unknown instance biblionumber > 427
* Final output is: Total 435 records indexed

Apply the patch

* run the same command again:
  debian/scripts/koha-elasticsearch --rebuild -b -v --where 'biblionumber > 427'  kohadev
* output should be
 Checking state of biblios index
 Indexing biblios
 Committing final records...
 Total 11 records indexed

* Run `debian/scripts/koha-elasticsearch --help`
* "-w|--where" should show up in the docs

Sponsored-by: HKS3
Sponsored-by: Koha DACH Hackfest
Signed-off-by: John Doe <you@example.com>
Signed-off-by: Anke Bruns <anke.bruns@gwdg.de>