Test plan 1. KOHA_IMAGE=main-bookworm ktd up 2. prove t/00-testcritic.t 3. pass 4. KOHA_IMAGE=main-trixie ktd up 5. prove t/00-testcritic Failed test 'Test::Perl::Critic for "C4/Members/Messaging.pm"' Code before strictures are enabled at line 23, column 1. See page 429 of PBP. (Severity: 5) It can be fixed by adding use strict; or use Modern::Perl; Is that just a forgotten occurrence? Severity = major because it makes the CI fail and hides issues even if not as much as Bug 40680. Maybe critical, I don't know.
Actually this one might be invalid as it looks like it's caused by https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=40680&attachment=187123 Doesn't look like a problem on master - it should be fixed on bug 40680 I think
I'll add the dependency here in any case as I guess it could be handled separately if necessary, but it's a bug created by bug 40680
Fixed inline in bug 40680.