Bug 40977 - t/00-testcritic.t fails on Debian 13
Summary: t/00-testcritic.t fails on Debian 13
Status: RESOLVED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 40680
Blocks:
  Show dependency treegraph
 
Reported: 2025-10-08 22:28 UTC by Victor Grousset/tuxayo
Modified: 2025-10-09 07:13 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Grousset/tuxayo 2025-10-08 22:28:03 UTC
Test plan
1. KOHA_IMAGE=main-bookworm ktd up
2. prove t/00-testcritic.t
3. pass
4. KOHA_IMAGE=main-trixie ktd up
5. prove t/00-testcritic
Failed test 'Test::Perl::Critic for "C4/Members/Messaging.pm"'
Code before strictures are enabled at line 23, column 1.  See page 429 of PBP.  (Severity: 5)

It can be fixed by adding
use strict;
or
use Modern::Perl;

Is that just a forgotten occurrence?

Severity = major because it makes the CI fail and hides issues even if not as much as Bug 40680. Maybe critical, I don't know.
Comment 1 David Cook 2025-10-08 23:27:31 UTC
Actually this one might be invalid as it looks like it's caused by https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=40680&attachment=187123

Doesn't look like a problem on master - it should be fixed on bug 40680 I think
Comment 2 David Cook 2025-10-08 23:28:17 UTC
I'll add the dependency here in any case as I guess it could be handled separately if necessary, but it's a bug created by bug 40680
Comment 3 Jonathan Druart 2025-10-09 07:13:10 UTC
Fixed inline in bug 40680.