See changes in follow-up on bug 40272. It would not harm to check if the metadata we got, is really a marc record object.
Created attachment 187981 [details] [review] Bug 41031: Add checks on metadata and biblio in Extractor::MARC->new Test plan: Run t/db_dependent/Koha/Biblio/Metadata/Extractor/MARC.t Verify that addbiblio.pl still opens as expected when modifying an existing record or adding a new record. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 187982 [details] [review] Bug 41031: Fix the subtest check_fixed_length in MARC21.t Add test on empty marc object. Remove MARC21 module and create with parent MARC object. Test plan: Run t/db_dependent/Koha/Biblio/Metadata/Extractor/MARC/MARC21.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 189264 [details] [review] Bug 41031: Add checks on metadata and biblio in Extractor::MARC->new Test plan: Run t/db_dependent/Koha/Biblio/Metadata/Extractor/MARC.t Verify that addbiblio.pl still opens as expected when modifying an existing record or adding a new record. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 189265 [details] [review] Bug 41031: Fix the subtest check_fixed_length in MARC21.t Add test on empty marc object. Remove MARC21 module and create with parent MARC object. Test plan: Run t/db_dependent/Koha/Biblio/Metadata/Extractor/MARC/MARC21.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
No problems here. Works as expected, good test coverage, QA tools are happy. PQA.
Created attachment 189342 [details] [review] Bug 41031: Add checks on metadata and biblio in Extractor::MARC->new Test plan: Run t/db_dependent/Koha/Biblio/Metadata/Extractor/MARC.t Verify that addbiblio.pl still opens as expected when modifying an existing record or adding a new record. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 189343 [details] [review] Bug 41031: Fix the subtest check_fixed_length in MARC21.t Add test on empty marc object. Remove MARC21 module and create with parent MARC object. Test plan: Run t/db_dependent/Koha/Biblio/Metadata/Extractor/MARC/MARC21.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(In reply to Lucas Gass (lukeg) from comment #7) > Signed-off-by: Owen Leonard <oleonard@myacpl.org> > Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Thx Owen and Lucas
Nice work everyone! Pushed to main for 25.11