PTFS Europe in etc/koha-conf.xml <plugin_repos> Needs to be changed ?
I think I've figured out the file to change in Koha to update the repository information: debian/templates/koha-conf-site.xml.in However, I'm not sure how to get these changes to take effect when using koha-testing-docker. 1. A reset_all or shutting down KTD and starting it up again with a patch applied don't update KTD's /etc/koha/sites/kohadev/koha-conf.xml 2. When Solutions inLibro was added in bug 33776, debian/templates/koha-conf-site.xml.in was the only file changed. 3. So, I think for testing purposes, you need to manually update /etc/koha/sites/kohadev/koha-conf.xml and restart everything. 4. To fix KTD, I think I need to do a request to update koha-testing-docker, files/templates/koha-conf-site.xml.in Other notes: - There are also repositories listed in etc/koha-conf.xml, but maybe this is generated when things are packaged/the packages are built? - I have a patch ready to go, but searching seems very flaky and inconsistent results, probably related to Bug 25952 - Github search for plugin throwing errors due to API rate limits Looking at the original bug that added this, Bug 23975 - Add ability to search and install plugins from GitHub, these were the only files changed. Or is this one of those things that are changed when the packages are built? 1. Apply this patch. 2. Copy the <plugin_repos> block from debian/templates/koha-conf-site.xml.in to /etc/koha/sites/kohadev/koha-conf.xml 2.1 This block should now include details for inLibro's repository. 2.2 Remove the comment lines (<!-- and -->). 3. Restart everything (flush_memcached and then restart_all). 4. Go to the plugins home page (Administration > Plugins > Manage plugins). 5. In the 'Search for plugins' search box (under and to the right of the Plugins heading), search for carrousel 6. The search results should include the koha-plugin-carrousel, with the organization show as Solutions inLibro.
This is not a Koha bug, but a KTD bug. Closing.
I got it wrong :-D
Created attachment 189851 [details] [review] Bug 41032: Fix Open Fifth missing in plugin repos config Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Created attachment 189862 [details] [review] Bug 41032: Fix Open Fifth missing in plugin repos config Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
(In reply to David Nind from comment #1) > > Looking at the original bug that added this, Bug 23975 - Add ability to > search and install plugins from GitHub, these were the only files changed. > > Or is this one of those things that are changed when the packages are built? > > 1. Apply this patch. > 2. Copy the <plugin_repos> block from debian/templates/koha-conf-site.xml.in > to /etc/koha/sites/kohadev/koha-conf.xml > 2.1 This block should now include details for inLibro's repository. > 2.2 Remove the comment lines (<!-- and -->). > 3. Restart everything (flush_memcached and then restart_all). > 4. Go to the plugins home page (Administration > Plugins > Manage plugins). > 5. In the 'Search for plugins' search box (under and to the right of the > Plugins heading), search for carrousel > 6. The search results should include the koha-plugin-carrousel, with the > organization show as Solutions inLibro. Please ignore these notes in Comment #1 - they were working notes that I forgot to remove.
I've signed off, but wasn't sure exactly how to test using KTD. With the changes made, instances created should have the correct repository details. For KTD, does files/templates/koha-conf-site.xml.in need updating?
Created attachment 189901 [details] [review] Bug 41032: Fix Open Fifth missing in plugin repos config Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
(In reply to David Nind from comment #7) > > For KTD, does files/templates/koha-conf-site.xml.in need updating? That's done, David. Thanks for the reminder!
(In reply to Tomás Cohen Arazi (tcohen) from comment #9) > (In reply to David Nind from comment #7) > > > > For KTD, does files/templates/koha-conf-site.xml.in need updating? > > That's done, David. Thanks for the reminder! Awesome! Thanks Tomás!
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x
Pushed to 24.11.x for 24.11.11