From bug 30724: The (followup) patch fixes the selenium tests but they are not correct IMO. We still need new tests to cover changes from this bug report.
Created attachment 188995 [details] [review] Bug 41038: Add tests for superlibrarian managing other users' 2FA Adds comprehensive selenium tests for the new functionality where superlibrarians can manage 2FA settings for other patrons. To test: 1. Run the existing authentication_2fa.t selenium tests 2. Notice missing coverage for cross-user 2FA management 3. Apply the patch 4. Run the tests again 5. Verify new subtests pass: - Superlibrarian can view/disable other users' 2FA - Enable button is hidden with explanatory message - Non-superlibrarian gets 403 error for other users
Created attachment 188999 [details] [review] Bug 41038: Add tests for superlibrarian managing other users' 2FA Adds comprehensive selenium tests for the new functionality where superlibrarians can manage 2FA settings for other patrons. To test: 1. Run the existing authentication_2fa.t selenium tests 2. Notice missing coverage for cross-user 2FA management 3. Apply the patch 4. Run the tests again 5. Verify new subtests pass: - Superlibrarian can view/disable other users' 2FA - Enable button is hidden with explanatory message - Non-superlibrarian gets 403 error for other users Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 189602 [details] [review] Bug 41038: Add tests for superlibrarian managing other users' 2FA Adds comprehensive selenium tests for the new functionality where superlibrarians can manage 2FA settings for other patrons. To test: 1. Run the existing authentication_2fa.t selenium tests 2. Notice missing coverage for cross-user 2FA management 3. Apply the patch 4. Run the tests again 5. Verify new subtests pass: - Superlibrarian can view/disable other users' 2FA - Enable button is hidden with explanatory message - Non-superlibrarian gets 403 error for other users Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x
Reverted from 25.05.x as we don't have Bug 30724. Looked for deps in "Depends on". Please use the metadata fields :)