Bug 41045 - Suggestions manage permissions added to patrons who previously had no permissions in that category
Summary: Suggestions manage permissions added to patrons who previously had no permiss...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 33363
Blocks:
  Show dependency treegraph
 
Reported: 2025-10-17 12:20 UTC by Emmi Takkinen
Modified: 2025-10-20 06:24 UTC (History)
16 users (show)

See Also:
GIT URL:
Sponsorship status: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Emmi Takkinen 2025-10-17 12:20:51 UTC
Bug 33363 separated suggestions_manage permission in three permissions for creating, updating, and deleting suggetions. In bugs test plan and in its atomicupdate file it is stated that these permissions should have been added only for those users who previously had suggestions_manage permissions. However there is a typo on SQL insert statement and new permissions have been added to all users with full catalogue permissions:

>INSERT IGNORE INTO user_permissions (borrowernumber, module_bit, code) SELECT borrowernumber, 12, 'suggestions_create' FROM borrowers WHERE flags & (1 << 2)
Comment 1 David Cook 2025-10-20 05:57:58 UTC
I'm just about to finish for the day, so I get you to just rephrase this one? What's "full catalogue permissions"?
Comment 2 Katrin Fischer 2025-10-20 06:24:44 UTC
(In reply to David Cook from comment #1)
> I'm just about to finish for the day, so I get you to just rephrase this
> one? What's "full catalogue permissions"?

Usually referring to the module level checkbox instead of sub-permissions.