Bug 4110 - Improve consistency and reliability of the interfaces to Members
Summary: Improve consistency and reliability of the interfaces to Members
Status: RESOLVED MOVED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: PC All
: P5 - low enhancement (vote)
Assignee: Colin Campbell
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-04 03:00 UTC by Colin Campbell
Modified: 2016-06-19 22:04 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:23:16 UTC


---- Reported by colin.campbell@ptfs-europe.com 2010-02-04 15:00:20 ----

Inspired by http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4108

Work should be done to make the Members interface more consistent.

Don't pass hashes but hash_refs to avoid runtime bugs due to missing or undefined values.

Some of the routines are fairly ubiquitous it may be more efficient to separate out the core calls rather than pass through a more generalized routine. 

Check that returns are rational

Probably a lot more once we look under the bonnet

To be addressed after 3.2 is out



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:23 UTC  ---

This bug was previously known as _bug_ 4110 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4110

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.

Comment 1 Katrin Fischer 2014-11-02 08:46:04 UTC
I wonder if this bug is too broad and we should aim to have a few 'small step' bug reports instead.
Comment 2 Katrin Fischer 2016-06-19 22:04:50 UTC
Using hash_refs is now part of the coding guidelines. I assume part of this bug is resolved or will be resolved by switching over to Koha::Object and into the Koha::Patron... namespace.