Bug 41136 - Advanced doesn't search on SRU servers
Summary: Advanced doesn't search on SRU servers
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Z39.50 / SRU / OpenSearch Servers (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 40841
  Show dependency treegraph
 
Reported: 2025-10-29 20:04 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2025-10-29 20:37 UTC (History)
3 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41136: Allow advanced editor to search SRU servers (2.06 KB, patch)
2025-10-29 20:09 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 41136: Allow advanced editor to search SRU servers (2.06 KB, patch)
2025-10-29 20:34 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 41136: Allow advanced editor to search SRU servers (2.06 KB, patch)
2025-10-29 20:37 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2025-10-29 20:04:24 UTC
The advanced editor has a hardcoded use of 'zed' for the type of server, which implies Z39.50 and not SRU.
Comment 1 Tomás Cohen Arazi (tcohen) 2025-10-29 20:09:57 UTC
Created attachment 188596 [details] [review]
Bug 41136: Allow advanced editor to search SRU servers

This patch makes the advanced editor be able to search on SRU servers
also, instead of only Z39.50.
To test:
0. On a fresh KTD
1. Enable and open the cataloguing advanced editor
2. Click on 'Advanced >>' on the left column
=> FAIL: Only non-SRU targets are displayed
3. Apply this patch and reload
4. Repeat 2
=> SUCCESS: SRU server displayed!
=> SUCCESS: No authority server is displayed due to the change i.e.
behavior remains unchanged besides SRU support
5. Choose the sample SRU server and make a search
=> SUCCESS: Things work
6. Sign off :-D
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 2 Tomás Cohen Arazi (tcohen) 2025-10-29 20:10:00 UTC
This patch makes the advanced editor be able to search on SRU servers
also, instead of only Z39.50.
To test:
0. On a fresh KTD
1. Enable and open the cataloguing advanced editor
2. Click on 'Advanced >>' on the left column
=> FAIL: Only non-SRU targets are displayed
3. Apply this patch and reload
4. Repeat 2
=> SUCCESS: SRU server displayed!
=> SUCCESS: No authority server is displayed due to the change i.e.
behavior remains unchanged besides SRU support
5. Choose the sample SRU server and make a search
=> SUCCESS: Things work
6. Sign off :-D
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 3 Tomás Cohen Arazi (tcohen) 2025-10-29 20:34:58 UTC
Created attachment 188607 [details] [review]
Bug 41136: Allow advanced editor to search SRU servers

This patch makes the advanced editor be able to search on SRU servers
also, instead of only Z39.50.
To test:
0. On a fresh KTD
1. Enable and open the cataloguing advanced editor
2. Click on 'Advanced >>' on the left column
=> FAIL: Only non-SRU targets are displayed
3. Apply this patch and reload
4. Repeat 2
=> SUCCESS: SRU server displayed!
=> SUCCESS: No authority server is displayed due to the change i.e.
behavior remains unchanged besides SRU support
5. Choose the sample SRU server and make a search
=> SUCCESS: Things work
6. Sign off :-D
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi (tcohen) 2025-10-29 20:35:00 UTC
This patch makes the advanced editor be able to search on SRU servers
also, instead of only Z39.50.
To test:
0. On a fresh KTD
1. Enable and open the cataloguing advanced editor
2. Click on 'Advanced >>' on the left column
=> FAIL: Only non-SRU targets are displayed
3. Apply this patch and reload
4. Repeat 2
=> SUCCESS: SRU server displayed!
=> SUCCESS: No authority server is displayed due to the change i.e.
behavior remains unchanged besides SRU support
5. Choose the sample SRU server and make a search
=> SUCCESS: Things work
6. Sign off :-D
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 5 Tomás Cohen Arazi (tcohen) 2025-10-29 20:37:19 UTC
Created attachment 188608 [details] [review]
Bug 41136: Allow advanced editor to search SRU servers
Comment 6 Tomás Cohen Arazi (tcohen) 2025-10-29 20:37:21 UTC
This patch makes the advanced editor be able to search on SRU servers
also, instead of only Z39.50.
To test:
0. On a fresh KTD
1. Enable and open the cataloguing advanced editor
2. Click on 'Advanced >>' on the left column
=> FAIL: Only non-SRU targets are displayed
3. Apply this patch and reload
4. Repeat 2
=> SUCCESS: SRU server displayed!
=> SUCCESS: No authority server is displayed due to the change i.e.
behavior remains unchanged besides SRU support
5. Choose the sample SRU server and make a search
=> SUCCESS: Things work
6. Sign off :-D
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>