See bug 40559. Moving second patch here.
Created attachment 188767 [details] [review] Bug 41153: Clean up catalogue/MARCdetail.pl
Copying this here too: > (In reply to Jonathan Druart from comment #5) > > Also wondering.... > > > > next > > if ( $tagslib->{ $fields[$x_i]->tag() }->{ $subf[$i][0] > > }->{tab} // q{} ) ne > > $tabloop; # Note: defaulting to '0' changes behavior! > > > > Why? > > Since tabloop can be zero? Or do you mean something else? The if syntax: next if ( $var ) ne $tabloop;
(In reply to Marcel de Rooy from comment #2) > Copying this here too: > > > (In reply to Jonathan Druart from comment #5) > > > Also wondering.... > > > > > > next > > > if ( $tagslib->{ $fields[$x_i]->tag() }->{ $subf[$i][0] > > > }->{tab} // q{} ) ne > > > $tabloop; # Note: defaulting to '0' changes behavior! > > > > > > Why? > > > > Since tabloop can be zero? Or do you mean something else? > > > The if syntax: > next if ( $var ) ne $tabloop; Still not sure if I understand this question. But here if is a "statement modifier". What follows is handled as an EXPR. So ( $x // '' ) ne $t seems to be a valid expression. Please clarify if you still mean something else..
Created attachment 188797 [details] [review] Bug 41153: Clean up catalogue/MARCdetail.pl Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Combining SO and QA. This looks more exciting than it is :)