Bug 41262 - Duplicate import in Koha::Patron
Summary: Duplicate import in Koha::Patron
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 26744
Blocks:
  Show dependency treegraph
 
Reported: 2025-11-18 14:23 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2025-11-19 19:29 UTC (History)
2 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 41262: Remove duplicate `logaction` import (978 bytes, patch)
2025-11-18 14:26 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 41262: Remove duplicate `logaction` import (1.00 KB, patch)
2025-11-18 17:10 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2025-11-18 14:23:27 UTC
There's two `use C4::Log  qw( logaction );`. The newest coming from bug 26744.
Comment 1 Tomás Cohen Arazi (tcohen) 2025-11-18 14:26:49 UTC
Created attachment 189657 [details] [review]
Bug 41262: Remove duplicate `logaction` import

This patch removes a trivial duplicate import.

To test:
1. Apply the patch
2. Run:
  k$ prove t/db_dependent/Koha/Patron.t
=> SUCCESS: Tests don't break
3. Sign off :-D

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 2 Martin Renvoize (ashimema) 2025-11-18 17:10:05 UTC
Created attachment 189674 [details] [review]
Bug 41262: Remove duplicate `logaction` import

This patch removes a trivial duplicate import.

To test:
1. Apply the patch
2. Run:
  k$ prove t/db_dependent/Koha/Patron.t
=> SUCCESS: Tests don't break
3. Sign off :-D

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 3 Lucas Gass (lukeg) 2025-11-19 19:29:35 UTC
Nice work everyone!

Pushed to main for 25.11