Bug 41275 - VueJS: We should abandon type="vendor" resource attribute
Summary: VueJS: We should abandon type="vendor" resource attribute
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-11-19 17:27 UTC by Pedro Amorim
Modified: 2025-11-20 09:24 UTC (History)
4 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41275: Drop vendor in favor of relationshipSelect (6.78 KB, patch)
2025-11-19 17:30 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2025-11-19 17:27:09 UTC
It should be utilizing the relationshipSelect instead.
Comment 1 Pedro Amorim 2025-11-19 17:30:06 UTC
Created attachment 189717 [details] [review]
Bug 41275: Drop vendor in favor of relationshipSelect

This is only a PoC for AgreementResource. More are needed.
Type = 'vendor' was a measure taken at the time to solve the issue immediatelly, but we have since abstracted 'simple' relationships to use relationshipSelect and there's no reason to continue using type: 'vendor'.
The thing I'd like comments on here is that an API call is done by relationshipSelect, whereas before the vendors were coming from the vendorStore loaded in ERM. AFAIK, this vendorStore load in ERM is still required to populate the 'vendor' table column filter options.

Thoughts?
Comment 2 Matt Blenkinsop 2025-11-19 17:39:09 UTC
Could the table column not just be a searchable column rather than needing all vendors loading into a dropdown?