Bug 41282 - We should alert staff when a checked out item fills a different hold for a patron
Summary: We should alert staff when a checked out item fills a different hold for a pa...
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-11-21 18:46 UTC by Nick Clemens (kidclamp)
Modified: 2025-11-22 03:02 UTC (History)
4 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41282: Alert staff when patron's hold is filled at checkout (6.46 KB, patch)
2025-11-21 18:52 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 41282: Alert staff when patron's hold is filled at checkout (7.10 KB, patch)
2025-11-22 03:00 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2025-11-21 18:46:04 UTC
When an item is checked out and the patron has a hold on the biblio we will fill thart hold with the item in hand

Sometimes the hold this item fills has another copy that is already in transit or waiting on the shelf.

We need to alert staff when this happens
Comment 1 Nick Clemens (kidclamp) 2025-11-21 18:52:20 UTC
Created attachment 189870 [details] [review]
Bug 41282: Alert staff when patron's hold is filled at checkout

When an item is checked out and the patron has a hold on the biblio we will fill thart hold with the item in hand
Sometimes the hold this item fills has another copy that is already in transit or waiting on the shelf.
We need to alert staff when this happens

This patch adds a return of the hold from MoveReserve and adds an object message to the issue that is passed to the template
If the hold was waiting or in transit we additionally pass a message in the hold that is returned

To test:
 1 - Place a biblio level hold for a patron
 2 - Check an item from the biblio in and confirm the hold
 3 - Check out a different item from the biblio to the patron
 4 - Note the hold is filled, but there is no notice
 5 - Apply the patch
 6 - Repeat 1-3, note there is now a notice that a waiting hold was filled
 7 - Place another hold for the patron for delivery at current branch
 8 - Check the item in at a different branch and confirm transfer
 9 - Switch back to first branch and check a different item from the biblio out to the patron
10 - Confirm the hold is filled and you are notified that a hold in transit was filled
Comment 2 Andrew Fuerste-Henry 2025-11-21 19:44:17 UTC
I think this needs to tell the user when the waiting item is at a different library.

A wrinkle:
1 - place a bib-level hold for pickup at Fairfield
2 - check item from that bib in at Fairfield and confirm hold
3 - change library to Centerville
4 - check a different item from that bib out to your patron at Centerville
5 - Message reads "This item filled a hold that had another item waiting on the shelf for this patron, please check the holds shelf and check in any other copies." -- it'd be more helpful if it said "had another item waiting on the shelf *at Fairfield*"

Additionally, we may want to say "check in any other copies *waiting for this patron.*" That may be overly pedantic/picky, but staff don't want to check in *every* waiting copy of this title, only the one for this specific patron.
Comment 3 Nick Clemens (kidclamp) 2025-11-22 03:00:41 UTC
Created attachment 189892 [details] [review]
Bug 41282: Alert staff when patron's hold is filled at checkout

When an item is checked out and the patron has a hold on the biblio we will fill thart hold with the item in hand
Sometimes the hold this item fills has another copy that is already in transit or waiting on the shelf.
We need to alert staff when this happens

This patch adds a return of the hold from MoveReserve and adds an object message to the issue that is passed to the template
If the hold was waiting or in transit we additionally pass a message in the hold that is returned

To test:
 1 - Place a biblio level hold for a patron
 2 - Check an item from the biblio in and confirm the hold
 3 - Check out a different item from the biblio to the patron
 4 - Note the hold is filled, but there is no notice
 5 - Apply the patch
 6 - Repeat 1-3, note there is now a notice that a waiting hold was filled
 7 - Place another hold for the patron for delivery at current branch
 8 - Check the item in at a different branch and confirm transfer
 9 - Switch back to first branch and check a different item from the biblio out to the patron
10 - Confirm the hold is filled and you are notified that a hold in transit was filled
Comment 4 Nick Clemens (kidclamp) 2025-11-22 03:02:18 UTC
This will now include the name of the library where the item is waiting or intransit from

We could add more to the payload as needed.

We plan to add a message to the affected item after moving bug 17361 forward - Tomas is looking into that