Bug 32740 added an option to send overdue notices from the patrons home library, saying: When it's selected notification messages for overdues will be bundled and sent from the borrowing user's home library However, the other two options 'item homelibrary' and 'checkout library' also change which set of triggers are used. Currently the patron option will continue to use the triggers of the checkout library This is confusing
Created attachment 189969 [details] [review] Bug 41316: Use patrons homelibrary for selecting overdues that should be sent Currently the patron homelibrary option for OverdueNoticeFrom will select overdues for a branches triggers based on the issuing branch The other two options select the trigger/overdues based on the selection This patch alters the selection of overdues to match only for the patrons branch To test: 1 - Apply 41315 and follow the plan there 2 - Apply this bug and run the overdues script, assuming CPL is branch A: perl misc/cronjobs/overdue_notices.pl --triggered --library CPL --test --nomail -v -v 3 - No overdues should be triggered 4 - Run the script for one of the patrons home libraries, in my case MPL perl misc/cronjobs/overdue_notices.pl --triggered --library MPL --test --nomail -v -v 5 - Note only overdues for patrons from that branch are triggered