Bug 41329 - yarn install generates 2 warnings regarding datatables-.net-vue3
Summary: yarn install generates 2 warnings regarding datatables-.net-vue3
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low major
Assignee: Jonathan Druart
QA Contact: Paul Derscheid
URL:
Keywords:
Depends on: 38426
Blocks:
  Show dependency treegraph
 
Reported: 2025-11-28 09:06 UTC by Jonathan Druart
Modified: 2026-01-06 14:34 UTC (History)
5 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
26.05.00
Circulation function:


Attachments
Bug 41329: Add datatables.net@^1.13.1 jquery@^3.6.0 (1.17 KB, patch)
2025-11-28 09:08 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41329: Add datatables.net@^1.13.1 jquery@^3.6.0 (1.21 KB, patch)
2025-12-31 09:04 UTC, David Nind
Details | Diff | Splinter Review
Bug 41329: Add datatables.net@^1.13.1 jquery@^3.6.0 (1.27 KB, patch)
2026-01-02 15:19 UTC, Paul Derscheid
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-11-28 09:06:31 UTC
warning " > datatables.net-vue3@2.1.3" has unmet peer dependency "datatables.net@^1.13.1".                                                                                                                           
warning " > datatables.net-vue3@2.1.3" has unmet peer dependency "jquery@^3.6.0".    

How is that bad?
Comment 1 Jonathan Druart 2025-11-28 09:08:51 UTC
Created attachment 190012 [details] [review]
Bug 41329: Add datatables.net@^1.13.1 jquery@^3.6.0

warning " > datatables.net-vue3@2.1.3" has unmet peer dependency "datatables.net@^1.13.1".
warning " > datatables.net-vue3@2.1.3" has unmet peer dependency "jquery@^3.6.0".

Test plan:
yarn build should not show those 2 warnings after this patch is applied

@RM: You will need to push yarn.lock as well
Comment 2 Paul Derscheid 2025-11-28 10:00:04 UTC
So this is not directly a problem since datatables and jquery are available as globals in compatible versions.

On resolution, yarn just can't find them because they are not in package.json and not installed via that route yet.

The patch would add them, but we would still continue using the static version in koha-tmpl/{intranet,opac}-tmpl/lib/.

To make at least the datatables.net-vue use them, we would need to remove datatables.net and jquery from the externals field in rspack.config.js, but then they would get bundled inside the vue assets and that would essentially be duplication because they are already available as globals.

The better solution would be to either copy the version from node_modules to the static lib dirs at build time or to make Asset.pm scan node_modules.

Since we are essentially tracking the versions we use in package.json via this patch, just not copying it yet, it could still be a valid way to silence the warnings, but more work is needed here.
Comment 3 David Nind 2025-12-31 09:04:17 UTC
Created attachment 190786 [details] [review]
Bug 41329: Add datatables.net@^1.13.1 jquery@^3.6.0

warning " > datatables.net-vue3@2.1.3" has unmet peer dependency "datatables.net@^1.13.1".
warning " > datatables.net-vue3@2.1.3" has unmet peer dependency "jquery@^3.6.0".

Test plan:
yarn build should not show those 2 warnings after this patch is applied

@RM: You will need to push yarn.lock as well

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Paul Derscheid 2026-01-02 15:19:30 UTC
Created attachment 190829 [details] [review]
Bug 41329: Add datatables.net@^1.13.1 jquery@^3.6.0

warning " > datatables.net-vue3@2.1.3" has unmet peer dependency "datatables.net@^1.13.1".
warning " > datatables.net-vue3@2.1.3" has unmet peer dependency "jquery@^3.6.0".

Test plan:
yarn build should not show those 2 warnings after this patch is applied

@RM: You will need to push yarn.lock as well

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 5 Victor Grousset/tuxayo 2026-01-02 17:19:54 UTC
I was trying to replicate but didn't get the warning. David had it and told me they had a node_modules dir still lying around in their koha code dir. So it's possible the warning only happens under that condition (and maybe with the right old libs in node_modules). I wonder if other people correlate the warning with a node_modules still there?

Anyway, thanks Paul for the QA, I couldn't have tell if the patch would still make sense if the issue is old node_modules lying around.
Comment 6 Lucas Gass (lukeg) 2026-01-06 14:34:09 UTC
Nice work everyone!

Pushed to main for 26.05